squid: client: check mds down status before getting mds_gid_t from mdsmap #58480
squid: client: check mds down status before getting mds_gid_t from mdsmap #58480YiteGu wants to merge 2 commits intoceph:squidfrom
Conversation
…fails Fixes: https://tracker.ceph.com/issues/64089 Signed-off-by: Dhairya Parmar <dparmar@redhat.com> (cherry picked from commit 564dba3) (cherry picked from commit e99486e)
Get mds_gid_t from up of MDSMap, will cause to core dump if target
mds_rank_t does not exist up map:
from: src/mds/MDSMap.h
const auto& get_info(mds_rank_t m) const {
return mds_info.at(up.at(m));
}
reproduct:
1. ceph fs fail <fs_name>
2. curl -X GET "example.com:8080/api/cephfs/1/clients" ...
up.at(m) will cause to core dump.
Fixes: https://tracker.ceph.com/issues/61844
Signed-off-by: Yite Gu <yitegu0@gmail.com>
(cherry picked from commit 878463e)
joscollin
left a comment
There was a problem hiding this comment.
There are no backport trackers for this. Can't do QA for this PR. Please fix it.
This PR had tracker(https://tracker.ceph.com/issues/64606), How to let QA know it? |
You need to update the trackers appropriately. Look at other PRs how it's done. |
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
we rely mostly on the jenkins dashboard e2es for approving the PR. If that passes then I don't have any issues with merging this one. Btw @YiteGu you'll need to update the descriptions with proper trackers. You can check these examples on how it look like. There's also a guide that describes the process which says about a |
created new backport PR by |
backport tracker: https://tracker.ceph.com/issues/64606
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e