cls/rgw: define lc ops in terms of ObjectOperation instead of IoCtx#58448
Merged
cls/rgw: define lc ops in terms of ObjectOperation instead of IoCtx#58448
Conversation
Signed-off-by: Casey Bodley <cbodley@redhat.com>
clean up the lc functions that were supposed to be hidden by CLS_CLIENT_HIDE_IOCTX this allows rgw to use them asynchonously with rgw_rados_operate() and optional_yield, and warn about blocking calls that should be async Signed-off-by: Casey Bodley <cbodley@redhat.com>
babc35d to
8476a02
Compare
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
passed qa in https://pulpito.ceph.com/cbodley-2024-08-08_20:20:18-rgw-wip-cbodley-testing-distro-default-smithi/ still needs review please |
mattbenjamin
approved these changes
Aug 14, 2024
Contributor
mattbenjamin
left a comment
There was a problem hiding this comment.
this all looks good to me
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the IoCtx functions are synchronous and not meant to be used in rgw. replace them with ObjectOperation arguments for use with rgw_rados_operate() and optional_yield
these IoCtx functions should have been hidden by the
CLS_CLIENT_HIDE_IOCTXdefine, but that was never added to thergw_commontarget which uses themwhen enabling
rgw_asio_assert_yieldingfrom #58179 and running s3-tests,test_lifecycle_settriggers an assertion becauseRGWLC::set_bucket_config()didn't supportoptional_yieldShow available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e