squid: mds: dump formatter even for errors#58319
Merged
lxbsz merged 6 commits intoceph:squidfrom Jul 16, 2024
Merged
Conversation
And change second argument to std::string_view to have more flexible conversions. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit bd52d8c) Conflicts: src/common/admin_socket.cc
The admin_socker framework only dumps the formatter by default if the command succeeds. Fixes: a4dc881 Fixes: https://tracker.ceph.com/issues/66184 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 55a88a0)
Existing convention is that "css" is short for CachedStackStringStream while "ss" is stringstream. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 4229c27)
It's unpleasant to test for existence in json. Just dump an empty string if not present. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 48a25e3)
As it's being used for error output. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit b89e7d4)
The asok interface will mangle stdout if the command actually fails. The reason `flush path` is done via the asok interface is because the tell/asok interfaces were unified after these tests were written and `flush path` was only available via the asok interface. Fixes: https://tracker.ceph.com/issues/66184 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 715c951)
Member
Author
|
jenkins test api |
Member
|
This PR is under test in https://tracker.ceph.com/issues/66762. |
Member
|
Checked all the failures, they are all not related, please see |
lxbsz
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/66542
backport of #57673
parent tracker: https://tracker.ceph.com/issues/66184
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh