cmake: add WITH_SYSTEM_BLAKE3 and WITH_SYSTEM_XXHASH#58310
cmake: add WITH_SYSTEM_BLAKE3 and WITH_SYSTEM_XXHASH#58310
Conversation
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
61520a2 to
f8e6942
Compare
|
https://jenkins.ceph.com/job/ceph-pull-requests/138269/ |
f8e6942 to
1e161f0
Compare
bisected to commit "cmake: use xxHash's unofficial cmake support". no idea why 🤷 but i've added a commit that changes dbstore_lib to a static library as a workaround |
9ce7c1f to
13e994f
Compare
8f53137 to
d2c50ec
Compare
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
cmake complains about cyclical dependencies in dbstore:
```
CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):
"rgw_common" of type STATIC_LIBRARY
depends on "dbstore" (weak)
depends on "dbstore_lib" (weak)
depends on "sqlite_db" (weak)
"dbstore_lib" of type SHARED_LIBRARY
depends on "rgw_common" (weak)
depends on "dbstore" (weak)
depends on "sqlite_db" (weak)
"dbstore" of type STATIC_LIBRARY
depends on "dbstore_lib" (weak)
depends on "rgw_common" (weak)
depends on "sqlite_db" (weak)
"sqlite_db" of type STATIC_LIBRARY
depends on "dbstore_lib" (weak)
depends on "rgw_common" (weak)
depends on "dbstore" (weak)
depends on "dbstore_lib" (strong)
At least one of these targets is not a STATIC_LIBRARY. Cyclic dependencies are allowed only among static libraries.
```
as dbstore_lib is the only shared library in this cycle, make it static
Signed-off-by: Casey Bodley <cbodley@redhat.com>
store_test_fixture.cc includes and depends on BlueStore ceph_test_objectstore links to store_test_fixture to pick up this transitive dependency Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
make global a PUBLIC dependency, and remove global from all targets that depend on rgw_common. this gets the xxhash dependency into tests like unittest_rgw_cksum Signed-off-by: Casey Bodley <cbodley@redhat.com>
d2c50ec to
da5001a
Compare
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
based on#55076#58429 for nowcentos 9 and fedora have up-to-date blake3-devel and xxhash-devel packages. adds cmake options WITH_SYSTEM_BLAKE3/XXHASH (off by default) to build against those packages instead of their submodules. ceph.spec.in adds those rpm dependencies and tells cmake to use them
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e