Skip to content

mgr/dashboard: fix clone async validators with different groups#58286

Merged
nizamial09 merged 2 commits intoceph:mainfrom
rhcs-dashboard:clone-validation
Jun 28, 2024
Merged

mgr/dashboard: fix clone async validators with different groups#58286
nizamial09 merged 2 commits intoceph:mainfrom
rhcs-dashboard:clone-validation

Conversation

@nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Jun 26, 2024

scrnli_6_26_2024_6-48-53.PM.mp4

Providing a way to dynamically update the async validator based on the selector field so that when the selected value changes, the depended field like the clone name gets validated again against the new value

Fixes: https://tracker.ceph.com/issues/66703

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Providing a way to dynamically update the async validator based on the
selector field so that when the selected value changes, the depended
field like the clone name gets validated again against the new value

Fixes: https://tracker.ceph.com/issues/66703
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09 nizamial09 requested a review from cloudbehl June 26, 2024 13:27
@nizamial09 nizamial09 requested a review from a team as a code owner June 26, 2024 13:27
@nizamial09 nizamial09 requested review from afreen23 and removed request for a team June 26, 2024 13:27
Fixes: https://tracker.ceph.com/issues/65180
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 3d1a7c5)
Copy link
Contributor

@cloudbehl cloudbehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nizamial09
Copy link
Member Author

e2e is passing.

  CephFS Snapshot Management
    ✓ Create a CephFS Volume (7909ms)
    ✓ Snapshots tab without a subvolume
    ✓ Create a CephFS Subvolume (8026ms)
    ✓ Show the CephFS Snapshots view
    ✓ Create a CephFS Subvolume Snapshot (8482ms)
    ✓ Create a CephFS Subvolume Snapshot Clone (11105ms)
    ✓ Remove a CephFS Subvolume Snapshot Clone (10568ms)
    ✓ Remove a CephFS Subvolume Snapshot (6983ms)
    ✓ Remove a CephFS Subvolume (8265ms)
    ✓ Remove CephFS Volume (8083ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants