Skip to content

quincy: cephfs-journal-tool: Add preventive measures to avoid fs corruption#58280

Closed
joscollin wants to merge 5 commits intoceph:quincyfrom
joscollin:wip-66280-quincy
Closed

quincy: cephfs-journal-tool: Add preventive measures to avoid fs corruption#58280
joscollin wants to merge 5 commits intoceph:quincyfrom
joscollin:wip-66280-quincy

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Jun 26, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/66280
Fixes: https://tracker.ceph.com/issues/63811

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@joscollin joscollin requested a review from a team as a code owner June 26, 2024 11:48
@github-actions github-actions bot added this to the quincy milestone Jun 26, 2024
@joscollin joscollin mentioned this pull request Jun 26, 2024
Closed
@joscollin joscollin force-pushed the wip-66280-quincy branch 2 times, most recently from 6e1e862 to da5f2ac Compare June 26, 2024 15:09
@joscollin
Copy link
Member Author

joscollin commented Jun 27, 2024

jenkins test make check

@joscollin
Copy link
Member Author

joscollin commented Jun 27, 2024

jenkins test make check

@joscollin joscollin requested a review from a team July 17, 2024 05:32
@lxbsz
Copy link
Member

lxbsz commented Aug 2, 2024

This PR is under test in https://tracker.ceph.com/issues/67315.

@github-actions
Copy link

github-actions bot commented Oct 1, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

joscollin and others added 5 commits October 3, 2024 09:05
@joscollin
cephfs-journal-tool: Add warning messages during 'journal reset' and …
4ea6727 
…prevent execution on active fs

Fixes: https://tracker.ceph.com/issues/62925
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 57f7d8b)

Conflicts:
        src/tools/cephfs/JournalTool.cc
        - Resolved conflict caused by 728cdc3 is not backported to quincy.
        src/tools/cephfs/first-damage.py
        - Resolved conflict as first-damage.py doesn't exist in quincy.
@neesingh-rh @joscollin
mds: scrub repair does not clear earlier damage health status
fb2b132 
Fixes: https://tracker.ceph.com/issues/54557
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 5b56098)
@neesingh-rh @joscollin
qa: test cases for checking the health status after scrub repair
245d1c8 
Fixes: https://tracker.ceph.com/issues/54557
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 7f0cf0b)
@joscollin
qa: fix cephfs-journal-tool command options and make fs inactive
e5994db 
Fixes: https://tracker.ceph.com/issues/62925
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 0820b31)

Conflicts:
        qa/workunits/fs/damage/test-first-damage.sh
        - Resolved the conflict caused by b6867bb and it's previous changes
          not backported to quincy
@joscollin
doc: update 'journal reset' command with --yes-i-really-really-mean-it
96e0e6a 
Fixes: https://tracker.ceph.com/issues/62925
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 42953ec)

Conflicts:
        PendingReleaseNotes
        - Dropped the unrelated release notes cherry-picked automatically.
@joscollin
Copy link
Member Author

joscollin commented Oct 3, 2024

rebased

@joscollin
Copy link
Member Author

joscollin commented Oct 17, 2024

jenkins test make check

@vshankar
Copy link
Contributor

vshankar commented Jan 2, 2025

This PR is under test in https://tracker.ceph.com/issues/69400.

@vshankar
Copy link
Contributor

vshankar commented Feb 10, 2025

Quincy is EOL.

@vshankar vshankar closed this Feb 10, 2025
@joscollin joscollin deleted the wip-66280-quincy branch February 11, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cephfs Ceph File System documentation tests

Projects

None yet

Milestone

quincy

Development

Successfully merging this pull request may close these issues.

4 participants

@joscollin @lxbsz @vshankar @neesingh-rh