Skip to content

squid: qa: enhance per-client labelled perf counters test#58252

Merged
lxbsz merged 3 commits intoceph:squidfrom
joscollin:wip-66674-squid
Jul 16, 2024
Merged

squid: qa: enhance per-client labelled perf counters test#58252
lxbsz merged 3 commits intoceph:squidfrom
joscollin:wip-66674-squid

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Jun 25, 2024

Fixes: https://tracker.ceph.com/issues/66674
Fixes: https://tracker.ceph.com/issues/66679

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

joscollin and others added 3 commits June 25, 2024 13:52
Fixes: https://tracker.ceph.com/issues/65497
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 5337a12)
MDS_CLIENTS_BROKEN_ROOTSQUASH is generated and expected by
test_rootsquash_nofeature but it hasn't be added to ignorelist as a
result of which QA code marks the job as failed even though all tests
finished running successfully.

Introduced-by: bccc8ce
Fixes: https://tracker.ceph.com/issues/66075
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 281183d)
Ignores the unresponsive client caused by fs.fail() in test_per_client_labeled_perf_counters_on_client_reconnect

Fixes: https://tracker.ceph.com/issues/65497
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 5f2a3a7)
@github-actions github-actions bot added cephfs Ceph File System tests labels Jun 25, 2024
@github-actions github-actions bot added this to the squid milestone Jun 25, 2024
@joscollin joscollin changed the title squid: qa: enhance labelled perf counters tests in test_admin.py squid: qa: enhance per-client labelled perf counters test Jun 25, 2024
@joscollin joscollin added the wip-jcollin-testing-squid2 Assigned for review label Jul 1, 2024
@joscollin
Copy link
Member Author

This PR is under test in https://tracker.ceph.com/issues/66762.

@joscollin joscollin requested a review from a team July 10, 2024 08:16
Copy link
Member

@lxbsz lxbsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all the failures, they are all not related, please see 2024-07-09 in https://tracker.ceph.com/projects/cephfs/wiki/Squid.

@lxbsz lxbsz merged commit b6cda46 into ceph:squid Jul 16, 2024
@joscollin joscollin deleted the wip-66674-squid branch July 17, 2024 04:11
@joscollin joscollin removed the wip-jcollin-testing-squid2 Assigned for review label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants