quincy: tools/cephfs: recover alternate_name of dentries from journal#58234
Closed
batrick wants to merge 5 commits intoceph:quincyfrom
Closed
quincy: tools/cephfs: recover alternate_name of dentries from journal#58234batrick wants to merge 5 commits intoceph:quincyfrom
batrick wants to merge 5 commits intoceph:quincyfrom
Conversation
Member
|
This PR is under test in https://tracker.ceph.com/issues/67315. |
47f6a48 to
31384be
Compare
Member
Author
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69400. |
It's never a good idea to put new fields in the middle of other encoded values unless you're willing to break all backwards-compatibility. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit d27b115)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit a66e80a)
Looked like:
recover_dentries: updating root 0x0x1
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 7599d47)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 4b4cb54)
Right now the cephfs-journal-tool always uses the legacy encoding for dentries which will drop the alternate_name if ever set. Fixes: 39f3440 Fixes: https://tracker.ceph.com/issues/64602 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit bebec1f)
31384be to
26f9fa8
Compare
Contributor
|
Quincy is EOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.B. this drops the QA commit because fs:fscrypt does not exist in quincy.
backport tracker: https://tracker.ceph.com/issues/66594
backport of #55792
parent tracker: https://tracker.ceph.com/issues/64602
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh