qa: some test set refuse_client_session, so the cluster log is expected#58218
qa: some test set refuse_client_session, so the cluster log is expected#58218
refuse_client_session, so the cluster log is expected#58218Conversation
|
jenkins test api |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
(adding this to my future run but feel free to test this in others.) |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
@vshankar needs rebase. |
|
This PR is under test in https://tracker.ceph.com/issues/66850. |
| - \(MDS_CLIENTS_BROKEN_ROOTSQUASH\) | ||
| - report clients with broken root_squash implementation | ||
| - evicting unresponsive client | ||
| - as file system flag refuse_client_session is set |
There was a problem hiding this comment.
Hit this again, I'm thinking instead of just ignore this warning shouldn't we just fix the test cases ?
For example:
1015 def test_fs_rename_fails_for_non_existent_fs(self):
1016 """
1017 That renaming a non-existent file system fails.
1018 """
1019 self.run_ceph_cmd(f'fs fail {self.fs.name}')
1020 self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session true')
1021 sleep(5)
1022
1023 try:
1024 self.run_ceph_cmd("fs rename non_existent_fs new_fs --yes-i-really-mean-it")
1025 except CommandFailedError as ce:
1026 self.assertEqual(ce.exitstatus, errno.ENOENT, "invalid error code on renaming a non-existent fs")
1027 else:
1028 self.fail("expected renaming of a non-existent file system to fail")
1029 self.run_ceph_cmd(f'fs set {self.fs.name} joinable true')
1030 self.fs.wait_for_daemons()
1031 self.run_ceph_cmd(f'fs set {self.fs.name} refuse_client_session false')
Since the mountpoints won't used in the test cases, we should just unmount them in the beginning ?
There was a problem hiding this comment.
The clients are supposed to reconnect back (and the MDS should allow that) once the flag is unset, so unmounting clients is kind of taking away that check.
|
jenkins test api |
3 similar comments
|
jenkins test api |
|
jenkins test api |
|
jenkins test api |
|
rebase and pushed to hopefully get the failing api test to pass. |
|
jenkins retest this please |
|
jenkins retest this please |
…cted Fixes: http://tracker.ceph.com/issues/66639 Signed-off-by: Venky Shankar <vshankar@redhat.com>
|
Finally! |
Fixes: http://tracker.ceph.com/issues/66639
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e