test/objectstore/TestRocksdbOptionParse.cc: Fix race hazard#58194
test/objectstore/TestRocksdbOptionParse.cc: Fix race hazard#58194
Conversation
Race hazard - rocksdb does not register its threads until they start running, and only guarantees the threads have been created before returning. We need to be prepared to wait for the scheduler to run the threads to avoid false positives. Fixes: https://tracker.ceph.com/issues/66575 Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
|
jenkins retest this please |
|
@aclamk Can I ask you to review this simple fix to race hazard in a test case that generates occasional false positives - not sure who to assign it to, but as its a RocksDB test case I guess its most related to BlueStore. |
|
jenkıns test make check |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
jenkins test api |
tchaikov
left a comment
There was a problem hiding this comment.
lgtm. it turns out that RockSDB's own test also wait until all threads have been registered: https://github.com/facebook/rocksdb/blob/de376be2ba3c9f20de5eecfdaae2bb028893a17a/db/db_test.cc#L4973-L4994
Race hazard - rocksdb does not register its threads until they start running, and only guarantees the threads have been created before returning. We need to be prepared to wait for the scheduler to run the threads to avoid false positives from this test case.
Fixes: https://tracker.ceph.com/issues/66575
Signed-off-by: Bill Scales bill_scales@uk.ibm.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e