unittest_osdmap aborted during OSDMapTest.BUG_42485#57988
Merged
Conversation
The testcase is aborted during the call of clean_upmap_tp
thread. The function(clean_pg_upmaps) spawns a number
of worker threads to process a PGMapper job. The worker
thread fetch a job from the queue and then process the
job and call process_finish the job. The process function
of PGMapper class destroying the object and as worker thread
call _process_finish function it crashes because job pointer
has become a dangling pointer.
Solution: To avoid a crash destroy the object in _process_finish
instead of doing in _process.
Fixes: https://tracker.ceph.com/issues/62934
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
rzarzynski
approved these changes
Jun 12, 2024
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
LGTM. I think the relevant code is:
template<class T>
class WorkQueue : public WorkQueue_ {
// ...
void _void_process(void *p, TPHandle &handle) override {
_process(static_cast<T *>(p), handle);
}
void _void_process_finish(void *p) override {
_process_finish(static_cast<T *>(p));
}void ThreadPool::worker(WorkThread *wt)
{
// ...
wq->_void_process(item, tp_handle);
ul.lock();
wq->_void_process_finish(item);
processing--;
Contributor
|
I think this is all about a problem that is exercised by the |
Member
|
jenkins test api |
Member
|
jenkins test make check |
Member
|
jenkins test make check arm64 |
Member
|
jenkins test api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testcase is aborted during the call of clean_upmap_tp thread. The function(clean_pg_upmaps) spawns a number of worker threads to process a PGMapper job. The worker thread fetch a job from the queue and then process the job and call process_finish the job. The process function of PGMapper class destroying the object and as worker thread call _process_finish function it crashes because job pointer has become a dangling pointer.
Solution: To avoid a crash destroy the object in _process_finish
instead of doing in _process.
Fixes: https://tracker.ceph.com/issues/62934
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e