Skip to content

qa/tasks/vstart_runner: avoid deprecation warning#57881

Merged
batrick merged 1 commit intoceph:mainfrom
batrick:vstart-deprecation
Jun 11, 2024
Merged

qa/tasks/vstart_runner: avoid deprecation warning#57881
batrick merged 1 commit intoceph:mainfrom
batrick:vstart-deprecation

Conversation

@batrick
Copy link
Member

@batrick batrick commented Jun 4, 2024

/home/pdonnell/ceph/qa/tasks/vstart_runner.py:1280: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
time_elapsed = (datetime.datetime.utcnow() - started_at).total_seconds()

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the tests label Jun 4, 2024
@batrick batrick added cephfs Ceph File System needs-review dashboard and removed tests labels Jun 4, 2024
@batrick batrick mentioned this pull request Jun 4, 2024
14 tasks
@batrick batrick force-pushed the vstart-deprecation branch from 39f3a1c to acec209 Compare June 4, 2024 21:03
@github-actions github-actions bot added the tests label Jun 4, 2024
@batrick
Copy link
Member Author

batrick commented Jun 5, 2024

jenkins test dashboard cephadm

1 similar comment
@neesingh-rh
Copy link
Contributor

jenkins test dashboard cephadm

Copy link
Contributor

@neesingh-rh neesingh-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see during my local testing, forgot to raise one. https://github.com/ceph/ceph/blob/main/qa/tasks/vstart_runner.py#L1280 also requires change

    /home/pdonnell/ceph/qa/tasks/vstart_runner.py:1280: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
    time_elapsed = (datetime.datetime.utcnow() - started_at).total_seconds()

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick batrick force-pushed the vstart-deprecation branch from acec209 to 7658896 Compare June 5, 2024 12:41
@batrick
Copy link
Member Author

batrick commented Jun 5, 2024

I did see during my local testing, forgot to raise one. https://github.com/ceph/ceph/blob/main/qa/tasks/vstart_runner.py#L1280 also requires change

Thanks, I fixed it.

@batrick
Copy link
Member Author

batrick commented Jun 5, 2024

jenkins test dashboard cephadm

@batrick
Copy link
Member Author

batrick commented Jun 5, 2024

jenkins test api

@batrick
Copy link
Member Author

batrick commented Jun 5, 2024

jenkins test make check

1 similar comment
@batrick
Copy link
Member Author

batrick commented Jun 6, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Jun 6, 2024

jenkins test dashboard cephadm

@batrick
Copy link
Member Author

batrick commented Jun 7, 2024

jenkins test make check

1 similar comment
@batrick
Copy link
Member Author

batrick commented Jun 8, 2024

jenkins test make check

@batrick batrick requested review from a team, ivoalmeida, neesingh-rh and nizamial09 and removed request for a team June 8, 2024 19:55
@batrick batrick merged commit be04bf2 into ceph:main Jun 11, 2024
@batrick batrick deleted the vstart-deprecation branch June 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants