Conversation
7100f8f to
b5f0b63
Compare
b5f0b63 to
0c43d45
Compare
|
@Matan-B i checked few of the suites that use k=8-m=6 new added and it looks good, please review: |
| roles: | ||
| - [mon.a, mgr.y, osd.0] | ||
| - [mon.b, osd.1] | ||
| - [mon.c, osd.2] | ||
| - [mgr.x, osd.3, client.0] | ||
| overrides: | ||
| ceph: | ||
| conf: | ||
| osd: | ||
| osd shutdown pgref assert: true |
There was a problem hiding this comment.
../thrash/clusters offers only fixed-4.yaml which is different from k=2-m=2-crush original roles:. Is it intentional?
There was a problem hiding this comment.
@Matan-B well. it creates those roles, it doesn't mean it will use them
There was a problem hiding this comment.
k=2-m=2-crush is not part of ../thrash/clusters. IIUC, k=2-m=2-crush should be added there as well before removing it from erasure-code dir.
There was a problem hiding this comment.
@Matan-B we are creating more roles than we need, but we are not using all of them in the case of k=2-m=2
erasure-code mention:
erasure_code_profile:
name: jerasure22profile
plugin: jerasure
k: 2
m: 2
technique: reed_sol_van
crush-failure-domain: osd
There was a problem hiding this comment.
Ah, got it now.
Any other qa/erasure-code/*.yaml does not specify roles. So those should be removed from ec-rados-plugin=jerasure-k=2-m=2-crush.yaml and ec-rados-plugin=jerasure-k=8-m=6-crush.yaml respectively.
There was a problem hiding this comment.
Any other
qa/erasure-code/*.yamldoes not specify roles. So those should be removed fromec-rados-plugin=jerasure-k=2-m=2-crush.yamlandec-rados-plugin=jerasure-k=8-m=6-crush.yamlrespectively.
This can be added to the commit message
roles being set without overrides causing too many values to unpack (expected 1) Fixes: https://tracker.ceph.com/issues/66209 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
0c43d45 to
e5cd546
Compare
|
jenkins test make check |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
jenkins test make check |
roles being set without overrides causing too many values to unpack (expected 1)
Fixes: https://tracker.ceph.com/issues/66209
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e