Skip to content

test/librados: fix LibRadosIoECPP.CrcZeroWrite#57856

Merged
athanatos merged 3 commits intoceph:mainfrom
athanatos:sjust/wip-66226-ec-crc
Jun 13, 2024
Merged

test/librados: fix LibRadosIoECPP.CrcZeroWrite#57856
athanatos merged 3 commits intoceph:mainfrom
athanatos:sjust/wip-66226-ec-crc

Conversation

@athanatos
Copy link
Contributor

https://tracker.ceph.com/issues/66226

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

athanatos added 3 commits May 31, 2024 17:19
We can't rely on recreating the pool at the end of the test case because
failing an assert in CrcZeroWrite would skip it.  Instead, recreate the
pool in TearDown with other cleanup.

Signed-off-by: Samuel Just <sjust@redhat.com>
This seems to be what was intended.

Signed-off-by: Samuel Just <sjust@redhat.com>
…e to work

The mon command to enable ec overwrites succeeds once the mon commits
the update.  However, actual IOs won't suceed until the map is actually
propagated to OSDs.  Update set_allow_ec_overwrites to try performing
overwrites until it actually succeeds (with a 120s timelimit) before
returning.

Fixes: https://tracker.ceph.com/issues/66226
Signed-off-by: Samuel Just <sjust@redhat.com>
@athanatos athanatos requested review from a team and NitzanMordhai June 3, 2024 22:35
@athanatos
Copy link
Contributor Author

Without above fix: https://pulpito.ceph.com/sjust-2024-05-31_22:55:08-rados-wip-sjust-balanced-read-testing-2024-05-31-distro-default-smithi/
With above fix: https://pulpito.ceph.com/sjust-2024-06-02_21:20:28-rados-wip-sjust-balanced-read-testing-2024-06-02-distro-default-smithi/

While there are still quite a few outstanding failures, I didn't see any examples of this specific failure with this branch -- I think it's good to merge.

@athanatos athanatos requested a review from rzarzynski June 10, 2024 19:38
@rzarzynski
Copy link
Contributor

@NitzanMordhai?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants