Skip to content

qa/rados: don't pass --max_attr_len to ceph_test_rados unconditionally#57855

Merged
ljflores merged 1 commit intoceph:mainfrom
rzarzynski:wip-bug-66321
Jun 13, 2024
Merged

qa/rados: don't pass --max_attr_len to ceph_test_rados unconditionally#57855
ljflores merged 1 commit intoceph:mainfrom
rzarzynski:wip-bug-66321

Conversation

@rzarzynski
Copy link
Contributor

@rzarzynski rzarzynski commented Jun 3, 2024 •
edited by ljflores
Loading

Fixes: https://tracker.ceph.com/issues/66321

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the tests label Jun 3, 2024
@athanatos
Copy link
Contributor

athanatos commented Jun 3, 2024 •
edited
Loading

That yaml line should be added to the seastore tests before merge. Nvm, it's already there.

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Jun 3, 2024

Just to the record:

$ git show --name-only  45943555ea170e630218eb1ae107b606ba06f0a7
commit 45943555ea170e630218eb1ae107b606ba06f0a7
Author: Xuehan Xu <xuxuehan@qianxin.com>
Date:   Mon Mar 11 16:41:21 2024 +0800

    qa/suites/crimson-rados(-experimental): set max-attr-len to 8192 for crimson thrash
    tests
    
    Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

qa/suites/crimson-rados-experimental/seastore/basic/tasks/readwrite.yaml
qa/suites/crimson-rados/thrash/workloads/small-objects-balanced.yaml
qa/suites/crimson-rados/thrash/workloads/small-objects-localized.yaml
qa/suites/crimson-rados/thrash/workloads/small-objects.yaml
qa/tasks/rados.py

@rzarzynski
Copy link
Contributor Author

rzarzynski commented Jun 10, 2024

Note from bug scrub: I doubt we need a QA run over this but we'll get free one as the commit has been appended to the EC partial reads PR.

@ljflores
Copy link
Member

ljflores commented Jun 12, 2024 •
edited
Loading

@rzarzynski the thrash-old-clients tests were suffering from this bug. I scheduled a small subset of tests with your fix applied so we can get clear results:

Before: https://pulpito.ceph.com/lflores-2024-06-10_23:03:46-rados:thrash-old-clients-main-distro-default-smithi/
After: https://pulpito.ceph.com/lflores-2024-06-12_21:58:53-rados:thrash-old-clients-main-distro-default-smithi/

After should be green so feel free to use these results to decide on merging your PR.

@ljflores
Copy link
Member

ljflores commented Jun 13, 2024

@rzarzynski the thrash-old-clients tests were suffering from this bug. I scheduled a small subset of tests with your fix applied so we can get clear results:

Before: https://pulpito.ceph.com/lflores-2024-06-10_23:03:46-rados:thrash-old-clients-main-distro-default-smithi/ After: https://pulpito.ceph.com/lflores-2024-06-12_21:58:53-rados:thrash-old-clients-main-distro-default-smithi/

After should be green so feel free to use these results to decide on merging your PR.

Failures unrelated, tracked by:

@ljflores ljflores merged commit 3139c54 into ceph:main Jun 13, 2024
@ljflores ljflores mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athanatos athanatos athanatos approved these changes

@xxhdx1985126 xxhdx1985126 xxhdx1985126 approved these changes

@ljflores ljflores Awaiting requested review from ljflores

Assignees

No one assigned

Labels

bug-fix needs-qa tests wip-lflores-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rzarzynski @athanatos @ljflores @xxhdx1985126