quincy: mds: use regular dispatch for processing metrics#57679
Closed
batrick wants to merge 2 commits intoceph:quincyfrom
Closed
quincy: mds: use regular dispatch for processing metrics#57679batrick wants to merge 2 commits intoceph:quincyfrom
batrick wants to merge 2 commits intoceph:quincyfrom
Conversation
Member
|
This PR is under test in https://tracker.ceph.com/issues/67315. |
aa08130 to
2f3ff5d
Compare
Member
Author
|
jenkins test make check |
Member
Author
|
jenkins test api |
Member
Author
|
jenkins test api |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69400. |
There have been cases where the MDS does an undesirable failover because it misses heartbeat resets after a long recovery in up:replay. It was observed that the MDS was processing a flood of metrics messages from all reconnecting clients. This likely caused undersiable MetricAggregator::lock contention in the messenger threads while fast dispatching client metrics. Instead, use the normal dispatch where acquiring locks is okay to do. See-also: linux.git/f7c2f4f6ce16fb58f7d024f3e1b40023c4b43ff9 Fixes: https://tracker.ceph.com/issues/65658 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit ed1fe99)
Since these are no longer fast dispatched, we need to ensure they are processed in a timely fashion and ahead of any incoming requests. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit d56b502)
2f3ff5d to
6cc43d6
Compare
Contributor
|
Quincy is EOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/66189
backport of #57081
parent tracker: https://tracker.ceph.com/issues/65658
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh