src/test/librados; qa/suites/rados/singleton/all: remove cache tiering workload#57577
src/test/librados; qa/suites/rados/singleton/all: remove cache tiering workload#57577
Conversation
|
Should we also remove api_tier_pp? It causes many failures as well: |
I'll check this one too. |
There is a bug present in this test, but since we no longer support cache tiering starting in Reef, this test should be removed (in squid and reef only). Fixes: https://tracker.ceph.com/issues/56028 Signed-off-by: Laura Flores <lflores@ibm.com>
Cache tiering was deprecated in Reef, so this broken test should be removed. Fixes: https://tracker.ceph.com/issues/62839 Signed-off-by: Laura Flores <lflores@ibm.com>
d08e8c7 to
5101214
Compare
rzarzynski
left a comment
There was a problem hiding this comment.
If it passes QA, fine!
|
jenkins test make check |
|
jenkins test api |
|
@ljflores pls merge when all checks passed |
|
jenkins retest this please |
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
|
tier_cxx.cc includes several deduplication tests, which are independent of cache tiering. Is that OK? (for instance, ManifestRefRead)---cache tiering test, like LibRadosTwoPoolsPP.HitSetWrite, is not the deduplication test. |
Ah, thanks, I didn't notice that. I'll review the file and make sure only cache tiering items are removed. |
@ljflores For your information, the following tests are related to the deduplication test in tier_cxx.cc. SetRedirectRead |
|
This was added to a testing batch, but it should not be merged. |
|
@ljflores: should be the comment above interpreted as DNM? If so, is there any change since it? |
|
should suites/rados/thrash/workloads/cache-* be removed as well? |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
There is a bug present in this test, but since we no longer support cache tiering starting in Reef, this test should be removed (in squid and reef only).
Fixes: https://tracker.ceph.com/issues/56028
Fixes: https://tracker.ceph.com/issues/62839
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e