Skip to content

RGW\bucket notification tests: end-point agnostic + refactoring#57550

Merged
AliMasarweh merged 1 commit intoceph:mainfrom
AliMasarweh:wip-alimasa-bn-end-point
Jun 3, 2024
Merged

RGW\bucket notification tests: end-point agnostic + refactoring#57550
AliMasarweh merged 1 commit intoceph:mainfrom
AliMasarweh:wip-alimasa-bn-end-point

Conversation

@AliMasarweh
Copy link
Member

@AliMasarweh AliMasarweh commented May 19, 2024

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@AliMasarweh AliMasarweh requested a review from a team as a code owner May 19, 2024 14:26
@AliMasarweh AliMasarweh force-pushed the wip-alimasa-bn-end-point branch from 948f2fb to 4392603 Compare May 20, 2024 08:56
@yuvalif
Copy link
Contributor

yuvalif commented May 21, 2024

@AliMasarweh please open a tracker for this PR, and mark as "squid" backport.

  • it is a great improvement to our notification tests
  • without it, it wil be difficult to backport any other test fixes to squid

@yuvalif yuvalif mentioned this pull request May 21, 2024
Merged
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
yuvalif
yuvalif reviewed May 23, 2024
View reviewed changes
@yuvalif
Copy link
Contributor

yuvalif commented May 23, 2024

in a followup PR/commit please split http tests into their own task.
in this directory: https://github.com/ceph/ceph/tree/main/qa/suites/rgw/notifications/tasks
add another directory "http" similar to "others". but with test_http.yaml file:

tasks:
- notification-tests:
    client.0:
      extra_attr: ["http_test"]
      rgw_server: client.0

and in : https://github.com/ceph/ceph/blob/main/qa/tasks/notification_tests.py
add !http_test to: https://github.com/ceph/ceph/blob/main/qa/tasks/notification_tests.py#L223C8-L223C37

@AliMasarweh AliMasarweh force-pushed the wip-alimasa-bn-end-point branch 2 times, most recently from 596e3da to 9a971b1 Compare May 28, 2024 09:31
yuvalif
yuvalif reviewed May 28, 2024
View reviewed changes
@AliMasarweh AliMasarweh force-pushed the wip-alimasa-bn-end-point branch from 9a971b1 to 019a959 Compare May 29, 2024 09:09
@github-actions
Copy link

github-actions bot commented May 29, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@AliMasarweh AliMasarweh force-pushed the wip-alimasa-bn-end-point branch from 019a959 to 1f52afd Compare May 29, 2024 11:33
@AliMasarweh AliMasarweh force-pushed the wip-alimasa-bn-end-point branch from 1f52afd to 6a7a1a9 Compare May 30, 2024 09:24
@AliMasarweh
RGW\bucket notification tests: end-point agnostic + refactoring
ddb6a24 
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
@AliMasarweh AliMasarweh force-pushed the wip-alimasa-bn-end-point branch from 6a7a1a9 to ddb6a24 Compare May 30, 2024 14:26
@AliMasarweh
Copy link
Member Author

AliMasarweh commented May 30, 2024

passing teuthology run:
https://pulpito.ceph.com/alimasa-2024-05-30_14:26:24-rgw:notifications-wip-alimasa-bn-end-point-distro-default-smithi/

@AliMasarweh
Copy link
Member Author

AliMasarweh commented May 30, 2024

jenkins test api

2 similar comments
@AliMasarweh
Copy link
Member Author

AliMasarweh commented Jun 2, 2024

jenkins test api

@AliMasarweh
Copy link
Member Author

AliMasarweh commented Jun 2, 2024

jenkins test api

@AliMasarweh
Copy link
Member Author

AliMasarweh commented Jun 2, 2024

jenkins test windows

@yuvalif yuvalif self-requested a review June 3, 2024 12:47
@AliMasarweh AliMasarweh merged commit 65533a9 into ceph:main Jun 3, 2024
@yuvalif yuvalif mentioned this pull request Jun 6, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuvalif yuvalif yuvalif approved these changes

Assignees

No one assigned

Labels

rgw tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AliMasarweh @yuvalif