Skip to content

squid: mds: find a new head for the batch ops when the head is dead#57494

Merged
rishabh-d-dave merged 1 commit intoceph:squidfrom
lxbsz:wip-66052
Aug 19, 2024
Merged

squid: mds: find a new head for the batch ops when the head is dead#57494
rishabh-d-dave merged 1 commit intoceph:squidfrom
lxbsz:wip-66052

Conversation

@lxbsz
Copy link
Member

@lxbsz lxbsz commented May 16, 2024 •
edited
Loading

backport tracker: https://tracker.ceph.com/issues/66363

backport of #57553
parent tracker: https://tracker.ceph.com/issues/66124

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@lxbsz lxbsz requested a review from a team May 16, 2024 06:41
@github-actions github-actions bot added the cephfs Ceph File System label May 16, 2024
leonid-s-usov
leonid-s-usov suggested changes May 16, 2024
View reviewed changes
Copy link
Contributor

@leonid-s-usov leonid-s-usov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait with this backport until we complete investigating a different approach to fixing this issue.

@batrick batrick added this to the squid milestone May 17, 2024
@lxbsz
Copy link
Member Author

lxbsz commented Jun 5, 2024

Let's wait with this backport until we complete investigating a different approach to fixing this issue.

@leonid-s-usov @joscollin

Should I backport the recent merged #57553 to this PR ? Or raise a new one later after this getting merged ?

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Jun 5, 2024

I would prefer to have it here as one PR, but please reference the tickets correctly: this PR will be serving both backport tickets

@lxbsz
Copy link
Member Author

lxbsz commented Jun 5, 2024

I would prefer to have it here as one PR, but please reference the tickets correctly: this PR will be serving both backport tickets

Done, maybe we could just drop the first two commits ?

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Jun 5, 2024

Done, maybe we could just drop the first two commits ?

Yes! In that case, we should mark the corresponding backport tickets as "Rejected" and explain there in the comment that the other backport supersedes them.

@lxbsz
Copy link
Member Author

lxbsz commented Jul 11, 2024

jenkins retest this please

@lxbsz
mds: try to choose a new batch head in request_clientup()
3224385 
This will happen only for the client requests, not peer requests.
The 'mdr->killed' and 'mdr->dead' will always be set at the same
time when killing the client requests.

Fixes: https://tracker.ceph.com/issues/66124
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 73b266e)
@lxbsz
Copy link
Member Author

lxbsz commented Aug 2, 2024

This PR is under test in https://tracker.ceph.com/issues/67316.

rishabh-d-dave
rishabh-d-dave approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA run was successful - https://tracker.ceph.com/projects/cephfs/wiki/Squid#19-Aug-2024

@rishabh-d-dave rishabh-d-dave merged commit ae41c27 into ceph:squid Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

@joscollin joscollin joscollin approved these changes

+1 more reviewer

@leonid-s-usov leonid-s-usov leonid-s-usov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephfs Ceph File System wip-lxb-testing-squid2

Projects

None yet

Milestone

squid

Development

Successfully merging this pull request may close these issues.

5 participants

@lxbsz @leonid-s-usov @rishabh-d-dave @joscollin @batrick