Skip to content

qa/cephfs: pass MDS name, not FS name, to "ceph mds fail" cmd#57493

Merged
batrick merged 1 commit intoceph:mainfrom
rishabh-d-dave:qa-mds-fail-fix
May 23, 2024
Merged

qa/cephfs: pass MDS name, not FS name, to "ceph mds fail" cmd#57493
batrick merged 1 commit intoceph:mainfrom
rishabh-d-dave:qa-mds-fail-fix

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented May 16, 2024

Fixea: https://tracker.ceph.com/issues/65864

This commit originally resided at PR #57333 but has been separated since Patrick wanted 1 ticket per PR.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

This issue was not caught in original QA run because "ceph mds fail"
returns 0 even though MDS name received by it in argument is
non-existent. This is done for the sake of idempotency, however it
caused this bug to go uncaught.

Fixea: https://tracker.ceph.com/issues/65864
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@batrick
Copy link
Member

batrick commented May 16, 2024

jenkins test windows

@batrick
Copy link
Member

batrick commented May 16, 2024

jenkins test api

@batrick
Copy link
Member

batrick commented May 16, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented May 17, 2024

jenkins test make check arm64

@batrick
Copy link
Member

batrick commented May 17, 2024

This PR is under test in https://tracker.ceph.com/issues/66086.

@rishabh-d-dave rishabh-d-dave added the wip-rishabh-testing Rishabh's testing label label May 20, 2024
@rishabh-d-dave
Copy link
Contributor Author

This PR is under test in https://tracker.ceph.com/issues/66125.

@rishabh-d-dave
Copy link
Contributor Author

This PR is under test in https://tracker.ceph.com/issues/66162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants