Skip to content

qa: relocate subvol creation overrides and test#57459

Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom
mchangir:mds-snap_schedule-relocate-test-and-overrides-to-correct-location
Sep 16, 2024
Merged

qa: relocate subvol creation overrides and test#57459
rishabh-d-dave merged 1 commit intoceph:mainfrom
mchangir:mds-snap_schedule-relocate-test-and-overrides-to-correct-location

Conversation

@mchangir
Copy link
Contributor

@mchangir mchangir commented May 14, 2024 •
edited
Loading

To avoid test jobs list to grow beyond snap-schedule.

Fixes: https://tracker.ceph.com/issues/65829
Signed-off-by: Milind Changire mchangir@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added the cephfs Ceph File System label May 14, 2024
batrick
batrick requested changes May 17, 2024
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

2024-05-17 01:04:14,985.985 INFO:teuthology.suite:Using random seed=6174
2024-05-17 01:04:14,986.986 INFO:teuthology.suite.run:kernel sha1: distro
2024-05-17 01:04:15,228.228 INFO:teuthology.suite.run:ceph sha1 explicitly supplied
2024-05-17 01:04:15,228.228 INFO:teuthology.suite.run:ceph sha1: 81a3c1e6c488116ab9844fe5ad8db3ce6128ccce
2024-05-17 01:04:16,423.423 INFO:teuthology.suite.run:ceph version: 19.0.0-3722.g81a3c1e6
2024-05-17 01:04:16,686.686 INFO:teuthology.suite.run:ceph branch: mds-snap_schedule-relocate-test-and-overrides-to-correct-location 6d6374ca98bd0b09a5d709e1ee6821fcffd9503e
2024-05-17 01:04:16,690.690 INFO:teuthology.repo_utils:Cloning https://github.com/mchangir/ceph.git mds-snap_schedule-relocate-test-and-overrides-to-correct-location from upstream
2024-05-17 01:04:30,399.399 INFO:teuthology.suite.run:teuthology branch: main a771c3cd04bbdbdd87e898bc8a2abe9d693c14db
Traceback (most recent call last):
  File "/cephfs/home/pdonnell/teuthology/virtualenv/bin/teuthology-suite", line 8, in <module>
    sys.exit(main())
  File "/cephfs/home/pdonnell/teuthology/scripts/suite.py", line 226, in main
    return teuthology.suite.main(args)
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/__init__.py", line 145, in main
    run.prepare_and_schedule()
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/run.py", line 438, in prepare_and_schedule
    num_jobs = self.schedule_suite()
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/run.py", line 587, in schedule_suite
    configs = build_matrix(suite_path,
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/build_matrix.py", line 62, in build_matrix
    mat, first, matlimit = _get_matrix(path, subset, no_nested_subset)
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/build_matrix.py", line 72, in _get_matrix
    mat = _build_matrix(path, no_nested_subset=no_nested_subset)
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/build_matrix.py", line 132, in _build_matrix
    submat = _build_matrix(
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/build_matrix.py", line 152, in _build_matrix
    submat = _build_matrix(
  File "/cephfs/home/pdonnell/teuthology/teuthology/suite/build_matrix.py", line 80, in _build_matrix
    raise IOError('%s does not exist (abs %s)' % (path, os.path.abspath(path)))
OSError: /cephfs/home/pdonnell/src/github.com_mchangir_ceph_mds-snap_schedule-relocate-test-and-overrides-to-correct-location/qa/suites/fs/functional/subvol_versions/create_subvol_version_v1.yaml does not exist (abs /cephfs/home/pdonnell/src/github.com_mchangir_ceph_mds-snap_schedule-relocate-test-and-overrides-to-correct-location/qa/suites/fs/functional/subvol_versions/create_subvol_version_v1.yaml)

checked out your commit:

$ ls qa/suites/fs/functional/subvol_versions/
create_subvol_version_v1.yaml  create_subvol_version_v2.yaml

oops?

By the way, I think you need a % in this new test_snap_schedule directory. Please give it a try before requesting a new a review.

@batrick
Copy link
Member

batrick commented May 21, 2024

ping @mchangir

@mchangir
Copy link
Contributor Author

mchangir commented Jun 19, 2024

ping @mchangir

sorry about the trouble
I didn't mean to ask you to test this change
I just couldn't tell what I did was correct
the teuthology tree layout never ceases to confuse me
I just needed guidance on the file layout

@mchangir mchangir marked this pull request as draft June 19, 2024 10:04
@mchangir mchangir force-pushed the mds-snap_schedule-relocate-test-and-overrides-to-correct-location branch from 6d6374c to 5663c9f Compare June 19, 2024 10:04
@github-actions github-actions bot added the tests label Jun 19, 2024
@mchangir
Copy link
Contributor Author

mchangir commented Jun 19, 2024

  • rebased
  • converted to draft PR
  • testing in progress

@mchangir mchangir force-pushed the mds-snap_schedule-relocate-test-and-overrides-to-correct-location branch 5 times, most recently from 7ac7cf9 to 3656dec Compare June 19, 2024 11:12
@mchangir
Copy link
Contributor Author

mchangir commented Jun 19, 2024

I've executed a dry-run of the teuthology-suite command and there are no errors thrown. The $ operator also does the job of randomly choosing either of the YAMLs. Also, the % operator has been appropriately placed in the test_snap_schedule dir.

@mchangir mchangir marked this pull request as ready for review June 19, 2024 13:10
@github-actions
Copy link

github-actions bot commented Aug 18, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 18, 2024
@github-actions
Copy link

github-actions bot commented Aug 30, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@mchangir mchangir force-pushed the mds-snap_schedule-relocate-test-and-overrides-to-correct-location branch from 3656dec to a5b586b Compare August 30, 2024 08:04
@mchangir
Copy link
Contributor Author

mchangir commented Aug 30, 2024

rebased

@mchangir
Copy link
Contributor Author

mchangir commented Aug 30, 2024

This PR is under test in https://tracker.ceph.com/issues/67832.

@mchangir
Copy link
Contributor Author

mchangir commented Aug 30, 2024

Testing completed
Only 6 jobs spawned as expected without any --limit argument.

1 failing job has no relation with the PR.

@mchangir
Copy link
Contributor Author

mchangir commented Aug 30, 2024

jenkins test api

1 similar comment
@mchangir
Copy link
Contributor Author

mchangir commented Aug 31, 2024

jenkins test api

@mchangir
Copy link
Contributor Author

mchangir commented Aug 31, 2024

@vshankar This PR is ready for merge.
As for the conflicting file issue, the file has been relocated into a subdir of the tasks/ dir. There were no conflicts detected by git during the rebase either. The tests have already passed with the new changes seen in the yaml fragments.

@mchangir
Copy link
Contributor Author

mchangir commented Sep 3, 2024

@batrick please take a look at #57459 (comment)

@mchangir
qa: relocate subvol creation overrides and test
ef68253 
Fixes: https://tracker.ceph.com/issues/65829
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir mchangir force-pushed the mds-snap_schedule-relocate-test-and-overrides-to-correct-location branch from a5b586b to ef68253 Compare September 6, 2024 04:42
@mchangir
Copy link
Contributor Author

mchangir commented Sep 6, 2024

rebased

rishabh-d-dave
rishabh-d-dave approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a small note: This PR adds directory test_snap_schedule which stands out, since the convention in qa/fs/functional/tasks directory is to have same name as Python test file after removing prefix test_. Example admin for test_admin.py and volumes for test_volumes.py.

Since this PR has already been tested, let's not delay the merge and perhaps make this change on a separate PR.

@rishabh-d-dave
Copy link
Contributor

rishabh-d-dave commented Sep 16, 2024 •
edited
Loading

Leaving link to the comment which mentions that QA run ticket for this PR here for future reference - #57459 (comment)

@rishabh-d-dave rishabh-d-dave merged commit 4d96f43 into ceph:main Sep 16, 2024
This was referenced Sep 23, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@rishabh-d-dave rishabh-d-dave rishabh-d-dave approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchangir @batrick @rishabh-d-dave