TestErasureCodeShec_arguments: fix stack-use-after-scope by Svelar · Pull Request #57435 · ceph/ceph

Svelar · 2024-05-13T08:50:17Z

When sanitizer is enabled, unittest_erasure_code_shec_arguments shows,

==412235==ERROR: AddressSanitizer: stack-use-after-scope on address 0xffffca8362c0 at pc 0xaaaab4f1d2b8 bp 0xffffca8356d0 sp 0xffffca8356c8
READ of size 4 at 0xffffca8362c0 thread T0
    #0 0xaaaab4f1d2b4 in getint(std::initializer_list<int>) /root/ceph/src/test/erasure-code/TestErasureCodeShec_arguments.cc:46:21
    #1 0xaaaab4f25cac in int std::__invoke_impl<int, int (*&)(std::initializer_list<int>), std::initializer_list<int>&>(std::__invoke_other, int (*&)(std::initializer_list<int>), std::initializer_list<int>&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61:14
    #2 0xaaaab4f24e90 in std::__invoke_result<int (*&)(std::initializer_list<int>), std::initializer_list<int>&>::type std::__invoke<int (*&)(std::initializer_list<int>), std::initializer_list<int>&>(int (*&)(std::initializer_list<int>), std::initializer_list<int>&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96:14
    #3 0xaaaab4f248e8 in bool std::ranges::__any_of_fn::operator()<std::initializer_list<int>*, std::initializer_list<int>*, int (*)(std::initializer_list<int>), std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int> >(std::initializer_list<int>*, std::initializer_list<int>*, std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int>, int (*)(std::initializer_list<int>)) const /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/ranges_algo.h:109:30
    #4 0xaaaab4f1d72c in bool std::ranges::__any_of_fn::operator()<std::array<std::initializer_list<int>, 27ul>&, int (*)(std::initializer_list<int>), std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int> >(std::array<std::initializer_list<int>, 27ul>&, std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int>, int (*)(std::initializer_list<int>)) const /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/ranges_algo.h:120:9
    #5 0xaaaab4f0fca8 in create_table_shec432() /root/ceph/src/test/erasure-code/TestErasureCodeShec_arguments.cc:96:15
    #6 0xaaaab4f1b140 in main /root/ceph/src/test/erasure-code/TestErasureCodeShec_arguments.cc:361:3
    #7 0xffff9b9673f8 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #8 0xffff9b9674c8 in __libc_start_main csu/../csu/libc-start.c:392:3
    #9 0xaaaab4e5b8ac in _start (/root/ceph/build/bin/unittest_erasure_code_shec_arguments+0x11b8ac) (BuildId: c1fce44a2cd8b7e33e7f07b2de20b9a2f57c314a)

keep a as initializer_list could fix this error.

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

When sanitizer is enabled, unittest_erasure_code_shec_arguments shows, ``` ==412235==ERROR: AddressSanitizer: stack-use-after-scope on address 0xffffca8362c0 at pc 0xaaaab4f1d2b8 bp 0xffffca8356d0 sp 0xffffca8356c8 READ of size 4 at 0xffffca8362c0 thread T0 #0 0xaaaab4f1d2b4 in getint(std::initializer_list<int>) /root/ceph/src/test/erasure-code/TestErasureCodeShec_arguments.cc:46:21 #1 0xaaaab4f25cac in int std::__invoke_impl<int, int (*&)(std::initializer_list<int>), std::initializer_list<int>&>(std::__invoke_other, int (*&)(std::initializer_list<int>), std::initializer_list<int>&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61:14 #2 0xaaaab4f24e90 in std::__invoke_result<int (*&)(std::initializer_list<int>), std::initializer_list<int>&>::type std::__invoke<int (*&)(std::initializer_list<int>), std::initializer_list<int>&>(int (*&)(std::initializer_list<int>), std::initializer_list<int>&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96:14 #3 0xaaaab4f248e8 in bool std::ranges::__any_of_fn::operator()<std::initializer_list<int>*, std::initializer_list<int>*, int (*)(std::initializer_list<int>), std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int> >(std::initializer_list<int>*, std::initializer_list<int>*, std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int>, int (*)(std::initializer_list<int>)) const /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/ranges_algo.h:109:30 #4 0xaaaab4f1d72c in bool std::ranges::__any_of_fn::operator()<std::array<std::initializer_list<int>, 27ul>&, int (*)(std::initializer_list<int>), std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int> >(std::array<std::initializer_list<int>, 27ul>&, std::_Bind_front<bool (*)(unsigned int, int) noexcept, unsigned int>, int (*)(std::initializer_list<int>)) const /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/ranges_algo.h:120:9 #5 0xaaaab4f0fca8 in create_table_shec432() /root/ceph/src/test/erasure-code/TestErasureCodeShec_arguments.cc:96:15 #6 0xaaaab4f1b140 in main /root/ceph/src/test/erasure-code/TestErasureCodeShec_arguments.cc:361:3 ceph#7 0xffff9b9673f8 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 ceph#8 0xffff9b9674c8 in __libc_start_main csu/../csu/libc-start.c:392:3 ceph#9 0xaaaab4e5b8ac in _start (/root/ceph/build/bin/unittest_erasure_code_shec_arguments+0x11b8ac) (BuildId: c1fce44a2cd8b7e33e7f07b2de20b9a2f57c314a) ``` keep a as initializer_list could fix this error. Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>

Svelar · 2024-05-13T08:53:45Z

Ref:

#include <iostream>

const int *get(std::initializer_list<int> is) {
	return is.begin();
}

int main(int argc, char *argv[])
{
	auto p = get({1, 2, 3, 4});
	int i = *p;
}

Svelar · 2024-05-23T06:47:36Z

jenkins test windows

tchaikov · 2024-05-28T09:09:14Z

jenkins test windows

tchaikov · 2024-06-25T05:55:00Z

i will (hopefully) take a look later this week.

Svelar · 2024-08-05T07:46:47Z

ping? @tchaikov

tchaikov · 2024-08-06T00:56:06Z

src/test/erasure-code/TestErasureCodeShec_arguments.cc

        }
        if (std::popcount(avails) == 4) {
-	  auto a = to_array<std::initializer_list<int>>({
+          std::initializer_list<std::initializer_list<int>> a {


a is already a std::initializer_list<..> before this change. i don't understand what's the difference between before and after this change. which libstdc++ version are you using?

tchaikov · 2024-08-06T01:00:06Z

Ref:

#include <iostream>

const int *get(std::initializer_list<int> is) {
	return is.begin();
}

int main(int argc, char *argv[])
{
	auto p = get({1, 2, 3, 4});
	int i = *p;
}

this example does not match with what we have in TestErasureCodeShec_arguments.cc, where we do keep a around instead of creating a temporary variable and dereference an iterator of it.

github-actions · 2024-10-06T02:26:33Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

github-actions · 2024-11-05T03:04:13Z

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

tchaikov · 2025-06-29T02:30:26Z

created #64238 to address the same issue.

Svelar added the cleanup label May 13, 2024

Svelar requested a review from adamemerson May 13, 2024 08:50

github-actions bot added the tests label May 13, 2024

Svelar mentioned this pull request May 23, 2024

script/run-make: enable ASan #56537

Draft

14 tasks

tchaikov self-requested a review May 30, 2024 02:22

tchaikov reviewed Aug 6, 2024

View reviewed changes

github-actions bot added the stale label Oct 6, 2024

github-actions bot closed this Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TestErasureCodeShec_arguments: fix stack-use-after-scope#57435

TestErasureCodeShec_arguments: fix stack-use-after-scope#57435
Svelar wants to merge 1 commit intoceph:mainfrom
Svelar:asan_shec_arg

Svelar commented May 13, 2024

Uh oh!

Svelar commented May 13, 2024 •

edited

Loading

Uh oh!

Svelar commented May 23, 2024

Uh oh!

tchaikov commented May 28, 2024

Uh oh!

tchaikov commented Jun 25, 2024

Uh oh!

Svelar commented Aug 5, 2024

Uh oh!

tchaikov Aug 6, 2024 •

edited

Loading

Uh oh!

tchaikov commented Aug 6, 2024

Uh oh!

github-actions bot commented Oct 6, 2024

Uh oh!

github-actions bot commented Nov 5, 2024

Uh oh!

tchaikov commented Jun 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Svelar commented May 13, 2024

Contribution Guidelines

Checklist

Uh oh!

Svelar commented May 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Svelar commented May 23, 2024

Uh oh!

tchaikov commented May 28, 2024

Uh oh!

tchaikov commented Jun 25, 2024

Uh oh!

Svelar commented Aug 5, 2024

Uh oh!

tchaikov Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tchaikov commented Aug 6, 2024

Uh oh!

github-actions bot commented Oct 6, 2024

Uh oh!

github-actions bot commented Nov 5, 2024

Uh oh!

tchaikov commented Jun 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Svelar commented May 13, 2024 •

edited

Loading

tchaikov Aug 6, 2024 •

edited

Loading