crimson/os/seastore/object_data_handler: cleanup read()#57432
Merged
crimson/os/seastore/object_data_handler: cleanup read()#57432
Conversation
cyx1231st
commented
May 13, 2024
| pins, | ||
| [ctx, loffset, len, ¤t, &ret](auto &pin) | ||
| -> read_iertr::future<> { | ||
| ceph_assert(current <= (loffset + len)); |
Member
Author
There was a problem hiding this comment.
IIUC it should be current < (loffset + len), modified.
| ).si_then([&ret, &l_current, l_current_end, | ||
| e_key, e_len](auto extent) { | ||
| assert(e_key == extent->get_laddr()); | ||
| assert(e_len == extent->get_length()); |
Member
Author
There was a problem hiding this comment.
Replaced by simpler checks without is_indirect, the original asserts should have been preserved above.
14 tasks
cyx1231st
commented
May 14, 2024
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
… read() l_current is only allowed to be larger than pin_key for the first pin. Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Specifically, refactor based on read range, pin range and extent range. Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
To make it easier to read, make sure there are 2 spaces per nesting. Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
08ee029 to
1293bc9
Compare
Member
Author
|
Should be ready for review, cc @ljx023 |
myoungwon
approved these changes
May 16, 2024
Member
myoungwon
left a comment
There was a problem hiding this comment.
I think this is a nice cleanup for readability.
xxhdx1985126
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e