common/Formatter: use CachedStackStringStream for efficiency#57392
common/Formatter: use CachedStackStringStream for efficiency#57392
Conversation
|
jenkins test api |
|
jenkins test make check |
|
jenkins test make check arm64 |
rzarzynski
left a comment
There was a problem hiding this comment.
Generally LGTM. Just some minors.
A stringstream is incredibly expensive to construct, use a cached one. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
jenkins test make check |
|
jenkins test make check arm64 |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
This PR is under test in https://tracker.ceph.com/issues/66086. |
|
|
|
Is there any backport tracker created for this PR? |
not sure, it's not a bug fix? |
My PR #57695 uses |
|
You can backport this commit with #57695 to avoid conflicts. I had not intended to do so since this is mostly a cleanup. |
A stringstream is incredibly expensive to construct, use a cached one.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e