Skip to content

mgr/snap_schedule: correctly fetch mds_max_snaps_per_dir from mds#57388

Merged
vshankar merged 2 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-correctly-fetch-mds_max_snaps_per_dir-from-mds
Sep 6, 2024
Merged

mgr/snap_schedule: correctly fetch mds_max_snaps_per_dir from mds#57388
vshankar merged 2 commits intoceph:mainfrom
mchangir:mgr-snap_schedule-correctly-fetch-mds_max_snaps_per_dir-from-mds

Conversation

@mchangir
Copy link
Contributor

@mchangir mchangir commented May 10, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/65895
Signed-off-by: Milind Changire mchangir@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added pybind cephfs Ceph File System tests labels May 10, 2024
vshankar
vshankar reviewed May 13, 2024
View reviewed changes
@mchangir
Copy link
Contributor Author

mchangir commented Jun 5, 2024

@vshankar fyi - qa run with debug_finisher logs for fs volume ls issue

@github-actions
Copy link

github-actions bot commented Aug 4, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Aug 4, 2024
@vshankar vshankar removed the stale label Aug 5, 2024
@vshankar
Copy link
Contributor

vshankar commented Aug 5, 2024

@mchangir ping?

@mchangir
Copy link
Contributor Author

mchangir commented Aug 5, 2024

@mchangir ping?

This is waiting for #58547 to get merged.
Manual tests on a vstart cluster do well.
Nothing complicated to test in this PR.
We'll just need 1 more PR to weed out the subvolume removal race with snapshot creation in the test_snap_schedules.py before this PR can give a clean run.

@vshankar
Copy link
Contributor

vshankar commented Aug 12, 2024

This is waiting for #58547 to get merged.

That would be merged today 👍

@mchangir mchangir force-pushed the mgr-snap_schedule-correctly-fetch-mds_max_snaps_per_dir-from-mds branch from 1038005 to 0973555 Compare August 30, 2024 08:28
@mchangir
Copy link
Contributor Author

mchangir commented Aug 30, 2024

rebased

@mchangir
mgr/snap_schedule: correctly fetch mds_max_snaps_per_dir from mds
529cdd3 
Fixes: https://tracker.ceph.com/issues/65895
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir
qa: test fetching foreign config item
1fda7cb 
Signed-off-by: Milind Changire <mchangir@redhat.com>
@mchangir mchangir force-pushed the mgr-snap_schedule-correctly-fetch-mds_max_snaps_per_dir-from-mds branch from 0973555 to 1fda7cb Compare September 5, 2024 06:29
@mchangir
Copy link
Contributor Author

mchangir commented Sep 5, 2024

rebased

@mchangir
Copy link
Contributor Author

mchangir commented Sep 5, 2024

This PR is under test in https://tracker.ceph.com/issues/67917.

@mchangir
Copy link
Contributor Author

mchangir commented Sep 5, 2024

jenkins test make check

@mchangir
Copy link
Contributor Author

mchangir commented Sep 5, 2024

jenkins test make check arm64

@mchangir
Copy link
Contributor Author

mchangir commented Sep 6, 2024

QA Run: https://pulpito.ceph.com/mchangir-2024-09-05_08:40:59-fs-wip-mchangir-testing-20240905.063159-main-debug-distro-default-smithi/

1 failure has no relation with PR changes

@vshankar please review and approve

@vshankar
Copy link
Contributor

vshankar commented Sep 6, 2024

QA Run: https://pulpito.ceph.com/mchangir-2024-09-05_08:40:59-fs-wip-mchangir-testing-20240905.063159-main-debug-distro-default-smithi/

1 failure has no relation with PR changes

@vshankar please review and approve

Noted -- checking.

@vshankar vshankar merged commit 485717a into ceph:main Sep 6, 2024
This was referenced Sep 7, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System pybind tests wip-mchangir-testing3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mchangir @vshankar