Skip to content

squid: ceph.spec.in: remove command-with-macro line#57358

Merged
batrick merged 1 commit intoceph:squidfrom
batrick:squid-rpm-build-fix
Jun 10, 2024
Merged

squid: ceph.spec.in: remove command-with-macro line#57358
batrick merged 1 commit intoceph:squidfrom
batrick:squid-rpm-build-fix

Conversation

@batrick
Copy link
Member

@batrick batrick commented May 8, 2024 •
edited
Loading

Manual backport as the original PR has no tracker ticket.

@phlogistonjohn @batrick
ceph.spec.in: remove command-with-macro line
f0b2a65 
A comment clearly left as a breadcrumb for a node-proxy manpage is
causing (intermittent) build failures. Remove the line and hope
the manpage is added if/when appropriate.

Fixes: 0dd7364
Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 5f25005)
@batrick batrick added this to the v19.1.0 milestone May 8, 2024
@batrick
Copy link
Member Author

batrick commented May 8, 2024

jenkins test make check

3 similar comments
@batrick
Copy link
Member Author

batrick commented May 8, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented May 8, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented May 8, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented May 17, 2024

This PR is under test in https://tracker.ceph.com/issues/66101.

@batrick batrick modified the milestones: v19.1.0, v19.1.1 May 17, 2024
batrick
batrick commented May 22, 2024
View reviewed changes
Copy link
Member Author

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://tracker.ceph.com/issues/66101#note-1

@batrick batrick requested review from guits and phlogistonjohn May 22, 2024 17:59
@batrick
Copy link
Member Author

batrick commented May 22, 2024

Ready to merge.

@batrick
Copy link
Member Author

batrick commented Jun 8, 2024

@guits @phlogistonjohn please approve and merge.

phlogistonjohn
phlogistonjohn approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@batrick batrick merged commit 3f51ea3 into ceph:squid Jun 10, 2024
@batrick batrick deleted the squid-rpm-build-fix branch June 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@guits guits Awaiting requested review from guits

Assignees

No one assigned

Labels

build/ops

Projects

None yet

Milestone

v19.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@batrick @phlogistonjohn