Skip to content

Test: osd-recovery-space.sh extends the wait time for "recovery toofull"#57193

Merged
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-osd-recovery-standalone-test-wait-for-too-full
Jul 30, 2024
Merged

Test: osd-recovery-space.sh extends the wait time for "recovery toofull"#57193
yuriw merged 1 commit intoceph:mainfrom
NitzanMordhai:wip-nitzan-osd-recovery-standalone-test-wait-for-too-full

Conversation

@NitzanMordhai
Copy link
Contributor

@NitzanMordhai NitzanMordhai commented May 1, 2024

The osd-recovery-space test involves writing objects and expecting to receive the "toofull" flag.
If we don't wait long enough, we might check the "toofull" flag before all objects have completed writing, and the "toofull" status hasn't been activated yet.

The change will extend the waiting time and will also incorporate additional checks for the return code from the status wait.

Fixes: https://tracker.ceph.com/issues/44510

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

…ll".

The osd-recovery-space test involves writing objects and expecting to receive
the "toofull" flag.
If we don't wait long enough, we might check the "toofull" flag before all objects
have completed writing, and the "toofull" status hasn't been activated yet.

The change will extend the waiting time and will also incorporate additional
checks for the return code from the status wait.

Fixes: https://tracker.ceph.com/issues/44510
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
@NitzanMordhai NitzanMordhai requested a review from a team as a code owner May 1, 2024 06:25
@github-actions github-actions bot added the core label May 1, 2024
@NitzanMordhai
Copy link
Contributor Author

I ran the tests 60 times: https://pulpito.ceph.com/nmordech-2024-04-30_10:14:02-rados:standalone-main-distro-default-smithi/
the failures are not related

@rzarzynski
Copy link
Contributor

jenkins test api

@rzarzynski
Copy link
Contributor

@yuriw, @ljflores: putting needs-qa for mostly to honor the procedure. Rather low-risk change and in the suite.

Copy link
Contributor

@pereman2 pereman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NitzanMordhai
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants