reef: pybind/mgr: disable sqlite3/python autocommit#57190
Merged
reef: pybind/mgr: disable sqlite3/python autocommit#57190
Conversation
Member
Author
|
jenkins test api |
Contributor
|
Did anyone notice the following comment added to the original PR? |
Member
Author
Maybe, I will look into it. |
Member
Author
Member
Author
|
fix included, this is ready for QA |
This avoids an assertion in ::drop_active. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 3fca118)
In the same epoch, to simplify testing. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit e044140)
Some are for development purposes and should be filtered out by the dashboard. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 0d94eeb)
To catch unintentional autocommit by sqlite3. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit fdd0dde)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 8ac4bbc)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 1749edd)
Refactor common tasks and allow loading mgrmodules before unittests start. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 2f48dc9)
Otherwise you cannot use LocalDaemon.check_status. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 9748d0c)
This mirrors teuthology and makes it possible to check the exit status of a daemon. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit e2e2144)
That autocommit is properly turned off and that commits via context managers work as expected. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit fb82b6d)
SQLite3 and python's binding were both committing transactions at unintended points. Turn it off and stop using executescript. Fixes: https://tracker.ceph.com/issues/65494 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 6eacfe9)
I misunderstood autocommit=False in prior patches. The sqlite3 binding will still create transactions automatically which confused newer bindings using autocommit. So, turn off automatic transaction management completely to maintain backwards compatibility. Fixes: https://tracker.ceph.com/issues/69912 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit df49652)
c10300c to
bc619ac
Compare
Member
Author
|
trivial rebase |
ljflores
approved these changes
Feb 27, 2025
Member
|
Approved on behalf of core. Might also want to get an approval from @ceph/cephfs . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker:
backport of #56997
parent tracker: https://tracker.ceph.com/issues/65494
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh