Skip to content

reef: pybind/mgr: disable sqlite3/python autocommit#57190

Merged
batrick merged 13 commits intoceph:reeffrom
batrick:wip-65731-reef
Feb 28, 2025
Merged

reef: pybind/mgr: disable sqlite3/python autocommit#57190
batrick merged 13 commits intoceph:reeffrom
batrick:wip-65731-reef

Conversation

@batrick
Copy link
Member

@batrick batrick commented Apr 30, 2024

backport tracker:


backport of #56997
parent tracker: https://tracker.ceph.com/issues/65494

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@batrick batrick requested review from a team as code owners April 30, 2024 20:58
@batrick batrick added this to the reef milestone Apr 30, 2024
@batrick batrick added the pybind label Apr 30, 2024
@batrick batrick requested review from Pegonzal and avanthakkar and removed request for a team April 30, 2024 20:58
@batrick
Copy link
Member Author

batrick commented May 1, 2024

jenkins test api

@ronen-fr
Copy link
Contributor

Did anyone notice the following comment added to the original PR?
#56997 (comment)
Is there as issue there?
@batrick ?

@batrick batrick added the DNM label Feb 5, 2025
@batrick
Copy link
Member Author

batrick commented Feb 5, 2025

Did anyone notice the following comment added to the original PR? #56997 (comment) Is there as issue there? @batrick ?

Maybe, I will look into it.

@batrick
Copy link
Member Author

batrick commented Feb 12, 2025

@batrick
Copy link
Member Author

batrick commented Feb 17, 2025

DNM https://tracker.ceph.com/issues/69912

fix included, this is ready for QA

@batrick batrick removed the DNM label Feb 17, 2025
@yuriw yuriw removed the TESTED label Feb 18, 2025
batrick and others added 13 commits February 25, 2025 11:17
This avoids an assertion in ::drop_active.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 3fca118)
In the same epoch, to simplify testing.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit e044140)
Some are for development purposes and should be filtered out by the dashboard.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 0d94eeb)
To catch unintentional autocommit by sqlite3.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit fdd0dde)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 8ac4bbc)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 1749edd)
Refactor common tasks and allow loading mgrmodules before unittests start.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 2f48dc9)
These should have been part of the commit adding the tests.

Fixes: 9ebcbdb
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 440f25e)
Otherwise you cannot use LocalDaemon.check_status.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 9748d0c)
This mirrors teuthology and makes it possible to check the exit status of a
daemon.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit e2e2144)
That autocommit is properly turned off and that commits via context managers
work as expected.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit fb82b6d)
SQLite3 and python's binding were both committing transactions at unintended
points. Turn it off and stop using executescript.

Fixes: https://tracker.ceph.com/issues/65494
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 6eacfe9)
I misunderstood autocommit=False in prior patches. The sqlite3 binding will
still create transactions automatically which confused newer bindings using
autocommit.

So, turn off automatic transaction management completely to maintain backwards
compatibility.

Fixes: https://tracker.ceph.com/issues/69912
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
(cherry picked from commit df49652)
@batrick
Copy link
Member Author

batrick commented Feb 25, 2025

trivial rebase

@github-project-automation github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Feb 27, 2025
@ljflores
Copy link
Member

Approved on behalf of core. Might also want to get an approval from @ceph/cephfs .

@batrick batrick merged commit ad999df into ceph:reef Feb 28, 2025
9 of 11 checks passed
@batrick batrick deleted the wip-65731-reef branch February 28, 2025 00:29
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ceph-Dashboard Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants