quincy: mds: inode_t flags may not be protected by the policylock during set_vxattr#57178
Closed
batrick wants to merge 1 commit intoceph:quincyfrom
Closed
quincy: mds: inode_t flags may not be protected by the policylock during set_vxattr#57178batrick wants to merge 1 commit intoceph:quincyfrom
batrick wants to merge 1 commit intoceph:quincyfrom
Conversation
046f5e5 to
bc00318
Compare
Member
|
This PR is under test in https://tracker.ceph.com/issues/67315. |
bc00318 to
a382d75
Compare
Member
Author
|
jenkins test make check |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/69400. |
Member
Author
|
jenkins test make check |
The code logic had a serious defect that it would only execute xlock_policylock once such that a retry would then proceed to executing the vxattr setting. Fixes: https://tracker.ceph.com/issues/65496 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 2931860) Conflicts: src/mds/Server.cc: no quiesce in quincy
a382d75 to
2fab471
Compare
Contributor
|
Quincy is EOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this backport omits testing commits because
qa/tasks/cephfs/test_subvolume.pydoes not exist in quincy.backport tracker: https://tracker.ceph.com/issues/65713
backport of #56934
parent tracker: https://tracker.ceph.com/issues/65496
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh