squid: mds: inode_t flags may not be protected by the policylock during set_vxattr#57176
Merged
batrick merged 6 commits intoceph:squidfrom May 22, 2024
Merged
squid: mds: inode_t flags may not be protected by the policylock during set_vxattr#57176batrick merged 6 commits intoceph:squidfrom
batrick merged 6 commits intoceph:squidfrom
Conversation
or other uses. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 2c2782b)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 0c8d601)
So we can have a long-running lock on an inode for certain tests. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 7f1d066)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 8a0eceb)
When the policy xlock cannot be immediately acquired. Test-case: https://tracker.ceph.com/issues/65496 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 5370ede)
The code logic had a serious defect that it would only execute xlock_policylock once such that a retry would then proceed to executing the vxattr setting. Fixes: https://tracker.ceph.com/issues/65496 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 2931860)
Member
Author
|
jenkins test windows |
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/66101. |
batrick
commented
May 22, 2024
leonid-s-usov
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/65714
backport of #56934
parent tracker: https://tracker.ceph.com/issues/65496
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh