osd: CEPH_OSD_OP_FLAG_BYPASS_CLEAN_CACHE flag is passed from ECBackend#57137
Merged
osd: CEPH_OSD_OP_FLAG_BYPASS_CLEAN_CACHE flag is passed from ECBackend#57137
Conversation
…_deep_scrub as well as we did in ReplicatedBackend::be_deep_scrub Fixes: https://tracker.ceph.com/issues/65686 Signed-off-by: Md Mahamudur Rahaman Sajib <mahamudur.sajib@croit.io>
ifed01
approved these changes
May 2, 2024
Contributor
|
jenkins test windows |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/65798. |
rzarzynski
approved these changes
May 6, 2024
| uint32_t fadvise_flags = CEPH_OSD_OP_FLAG_FADVISE_SEQUENTIAL | | ||
| CEPH_OSD_OP_FLAG_FADVISE_DONTNEED; | ||
| CEPH_OSD_OP_FLAG_FADVISE_DONTNEED | | ||
| CEPH_OSD_OP_FLAG_BYPASS_CLEAN_CACHE; |
Contributor
There was a problem hiding this comment.
Just to the record:
CEPH_OSD_OP_FLAG_BYPASS_CLEAN_CACHE = 0x100, /* bypass ObjectStore cache, mainly for deep-scrub */
Contributor
|
@ronen-fr Can you take a look? |
Contributor
This was referenced May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while ago #23629 introduced CEPH_OSD_OP_FLAG_BYPASS_CLEAN_CACHE flag for deep-scrubbing to instruct ObjectStore to bypass buffer cache when reading whenever possible.
Now this flag is passed from ReplicatedBackend but it looks like ECBackend still lacks it. It is added here.
Fixes: https://tracker.ceph.com/issues/65686
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e