Skip to content

crimson/os/seastore: misc cleanups and fixes#57128

Merged
cyx1231st merged 6 commits intoceph:mainfrom
cyx1231st:wip-fix-ut-seastore-timeout
Apr 30, 2024
Merged

crimson/os/seastore: misc cleanups and fixes#57128
cyx1231st merged 6 commits intoceph:mainfrom
cyx1231st:wip-fix-ut-seastore-timeout

Conversation

@cyx1231st
Copy link
Member

@cyx1231st cyx1231st commented Apr 29, 2024

This is the misc cleanups and fixes during debugging.

Still trying to fix https://tracker.ceph.com/issues/65585.

Seem to me the blocking issue of test-seastore reveals a deadlock from background cleaning -- the IO transaction didn't proceed after a conflict. But I'm not able to root cause it yet, because adding more logs seem to make it unreproducible.

Update: cannot reproduce after #57129.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@cyx1231st cyx1231st force-pushed the wip-fix-ut-seastore-timeout branch from b9a8f2d to 03fdd45 Compare April 29, 2024 06:45
@xxhdx1985126
Copy link
Contributor

Please take a look at #57129

@cyx1231st cyx1231st force-pushed the wip-fix-ut-seastore-timeout branch from 03fdd45 to 7276b0e Compare April 29, 2024 08:45
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
…atomic

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
@cyx1231st cyx1231st force-pushed the wip-fix-ut-seastore-timeout branch from 7276b0e to 2a4b2e7 Compare April 29, 2024 08:57
@cyx1231st cyx1231st merged commit dc8a117 into ceph:main Apr 30, 2024
@cyx1231st cyx1231st deleted the wip-fix-ut-seastore-timeout branch April 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants