mds: set the correct WRLOCK flag always in wrlock_force()#57085
Merged
mds: set the correct WRLOCK flag always in wrlock_force()#57085
Conversation
batrick
reviewed
Apr 25, 2024
Member
Author
|
jenkins retest this please |
The wrlock is not like the xlock, which needs to be acquired in the CInode's auth always, and it is based on the CDir's auths instead. When a remote_wrlock is acquired and the local MDS will add a lock item and marks it as REMOTE_WRLOCK. And later when the local MDS try to force wrlock in the emplace_lock() will just return the existing lock item without updating the WRLOCK flag. So when cleaning the requests later it will just release the remote locks and then removes lock items directly, which will miss releasing the local wrlock reference. Fixes: https://tracker.ceph.com/issues/65630 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/66327. |
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/66522. |
vshankar
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrlock is not like the xlock, which needs to be acquired in
the CInode's auth always, and it is based on the CDir's auths instead.
When a remote_wrlock is acquired and the local MDS will add a lock
item and marks it as REMOTE_WRLOCK. And later when the local MDS try
to force wrlock in the emplace_lock() will just return the existing
lock item without updating the WRLOCK flag. So when cleaning the
requests later it will just release the remote locks and then removes
lock items directly, which will miss releasing the local wrlock
reference.
Fixes: https://tracker.ceph.com/issues/65630
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e