Skip to content

tools/ceph-dencoder: introduce add_crc32c command to append crc32 for…#56925

Merged
yuriw merged 1 commit intoceph:mainfrom
ifed01:wip-ifed-dencoder-crc32
Feb 13, 2025
Merged

tools/ceph-dencoder: introduce add_crc32c command to append crc32 for…#56925
yuriw merged 1 commit intoceph:mainfrom
ifed01:wip-ifed-dencoder-crc32

Conversation

@ifed01
Copy link
Contributor

@ifed01 ifed01 commented Apr 16, 2024

… the encoded buffer.
Sometimes we might need to recalculate encoded object crc and this looked like a non-trivial task before this patch.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@ifed01
Copy link
Contributor Author

ifed01 commented Apr 17, 2024

jenkins test api

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jun 16, 2024
@ifed01
Copy link
Contributor Author

ifed01 commented Jul 12, 2024

unstale

@github-actions github-actions bot removed the stale label Jul 12, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 10, 2024
@ifed01 ifed01 requested a review from rzarzynski September 11, 2024 10:26
@ifed01
Copy link
Contributor Author

ifed01 commented Sep 11, 2024

@rzarzynski - mind taking a look?

@github-actions github-actions bot removed the stale label Sep 11, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 10, 2024
@ifed01 ifed01 requested a review from sajibreadd November 13, 2024 12:40
@github-actions github-actions bot removed the stale label Nov 13, 2024
… the

encoded buffer.
Sometimes we might need to recalculate encoded object crc and this
looked like a non-trivial task before this patch.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
@ifed01 ifed01 force-pushed the wip-ifed-dencoder-crc32 branch from c8d556c to 5e3fd1e Compare November 14, 2024 11:22
@sajibreadd
Copy link
Member

jenkins test make check

1 similar comment
@ifed01
Copy link
Contributor Author

ifed01 commented Dec 16, 2024

jenkins test make check

@ifed01
Copy link
Contributor Author

ifed01 commented Dec 16, 2024

jenkins test api

@amathuria
Copy link
Contributor

@yuriw yuriw merged commit 2a6ba87 into ceph:main Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants