mgr/dashboard: Support Description and AccountId in rgw roles#56919
Merged
ivoalmeida merged 1 commit intoceph:mainfrom Apr 17, 2024
Merged
mgr/dashboard: Support Description and AccountId in rgw roles#56919ivoalmeida merged 1 commit intoceph:mainfrom
ivoalmeida merged 1 commit intoceph:mainfrom
Conversation
Contributor
Author
|
jenkins test api |
Fixes https://tracker.ceph.com/issues/65506 Rgw roles list page is crashing due to these new fields coming from api but not supported in dashboard frontend. This will also fix failing CI tests. Signed-off-by: Afreen <afreen23.git@gmail.com>
ab14968 to
bfa85ec
Compare
Contributor
|
@afreen23 Empty (string, list, object) should be blank as it doesn't look good. We can take it as part of usability work. |
Contributor
Author
|
jenkins test dashboard cephadm |
nizamial09
approved these changes
Apr 16, 2024
Member
nizamial09
left a comment
There was a problem hiding this comment.
Thank you for taking care of it. LGTM
Contributor
Author
|
jenkins test dashboard cephadm |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test dashboard cephadm |
1 similar comment
Contributor
Author
|
jenkins test dashboard cephadm |
Contributor
Author
|
jenkins test make check arm64 |
cloudbehl
approved these changes
Apr 17, 2024
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://tracker.ceph.com/issues/65506
Rgw roles list page is crashing due to these new fields coming from api but not supported in dashboard frontend.
This will also fix failing CI tests.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e