mgr/dashboard: provide hub Cluster HA for multi-cluster setup#56847
Merged
aaSharma14 merged 1 commit intoceph:mainfrom Apr 16, 2024
Merged
mgr/dashboard: provide hub Cluster HA for multi-cluster setup#56847aaSharma14 merged 1 commit intoceph:mainfrom
aaSharma14 merged 1 commit intoceph:mainfrom
Conversation
cloudbehl
reviewed
Apr 12, 2024
| inventory_hosts = [host.to_json() for host in orch.hosts.list()] | ||
| for host in inventory_hosts: | ||
| host_addr = host['addr'] | ||
| host_url = hub_url.replace(hostname, host_addr) |
Contributor
There was a problem hiding this comment.
Can this create issue if the user is operating over a hostname and the cors has ip addresses set. Can you check that usecase?
Contributor
Author
There was a problem hiding this comment.
Thanks @cloudbehl for pointing out, To cover this scenario we need to set the cross origin url with IP url and the fqdn as well. updated the PR accordingly.
06e2d2b to
209ff25
Compare
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins test dashboard |
Contributor
Author
|
jenkins test dashboard cephadm |
nizamial09
reviewed
Apr 16, 2024
Comment on lines
+114
to
+120
| orch = OrchClient.instance() | ||
| inventory_hosts = [host.to_json() for host in orch.hosts.list()] | ||
|
|
||
| for host in inventory_hosts: | ||
| host_addr = host['addr'] | ||
| host_ip_url = hub_url.replace(hostname, host_addr) | ||
| host_hostname_url = hub_url.replace(hostname, host['hostname']) |
Member
There was a problem hiding this comment.
this will break ceph-dev like environments right? where no orchestrator is available?
Contributor
Author
There was a problem hiding this comment.
@nizamial09 , works fine with ceph-dev as well
nizamial09
approved these changes
Apr 16, 2024
Fixes: https://tracker.ceph.com/issues/65499 Signed-off-by: Aashish Sharma <aasharma@redhat.com>
209ff25 to
44f04c0
Compare
Contributor
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a cluster to the multi-cluster setup, set all the mgr IP's as cross_origin_url in the connected cluster to provide HA for the hub cluster in case of a mgr failover
Fixes: https://tracker.ceph.com/issues/65499
Screencast.from.2024-04-12.11-16-07.webm
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e