Skip to content

crimson/osd/pg: introduce projected_log#56832

Merged
Matan-B merged 2 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-recovery-version
Nov 5, 2024
Merged

crimson/osd/pg: introduce projected_log#56832
Matan-B merged 2 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-recovery-version

Conversation

@Matan-B
Copy link
Copy Markdown
Contributor

@Matan-B Matan-B commented Apr 11, 2024 •
edited
Loading

Signed-off-by: Matan Breizman mbreizma@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@Matan-B Matan-B requested a review from a team as a code owner April 11, 2024 13:40
@Matan-B Matan-B mentioned this pull request Apr 11, 2024
Merged
14 tasks
athanatos
athanatos previously requested changes Apr 11, 2024
View reviewed changes
@Matan-B Matan-B force-pushed the wip-matanb-crimson-recovery-version branch 2 times, most recently from 61e5ba2 to 31fda70 Compare April 15, 2024 13:28
@Matan-B Matan-B requested a review from athanatos April 15, 2024 13:32
@Matan-B Matan-B mentioned this pull request Apr 15, 2024
Merged
14 tasks
@Matan-B Matan-B changed the title crimson/osd/replicated_recovery_backend: fix recovery_info version crimson/osd/pg: introduce projected_log Apr 16, 2024
@Matan-B Matan-B added the DNM label Apr 16, 2024
@Matan-B Matan-B changed the title crimson/osd/pg: introduce projected_log [WIP] crimson/osd/pg: introduce projected_log Apr 16, 2024
@Matan-B Matan-B force-pushed the wip-matanb-crimson-recovery-version branch from 31fda70 to 15b3411 Compare April 16, 2024 10:04
@Matan-B Matan-B changed the title [WIP] crimson/osd/pg: introduce projected_log crimson/osd/pg: introduce projected_log Apr 16, 2024
@Matan-B Matan-B requested review from a team and rzarzynski April 16, 2024 10:06
@Matan-B Matan-B added the DNM label Apr 16, 2024
@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Apr 16, 2024

DNM: makecheck errors, will get back to it.

rzarzynski
rzarzynski reviewed Apr 17, 2024
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 16, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jun 16, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 16, 2024

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jul 16, 2024
@Matan-B Matan-B reopened this Jul 21, 2024
@Matan-B Matan-B removed the stale label Jul 21, 2024
@Matan-B Matan-B mentioned this pull request Jul 22, 2024
Closed
14 tasks
@Matan-B Matan-B force-pushed the wip-matanb-crimson-recovery-version branch from 841b433 to 60be61a Compare October 30, 2024 09:46
@Matan-B Matan-B mentioned this pull request Oct 30, 2024
Merged
14 tasks
@Matan-B Matan-B requested a review from xxhdx1985126 October 30, 2024 09:51
@Matan-B Matan-B force-pushed the wip-matanb-crimson-recovery-version branch 2 times, most recently from c348376 to 034d665 Compare October 30, 2024 10:11
xxhdx1985126
xxhdx1985126 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@xxhdx1985126 xxhdx1985126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 3, 2024

jenkins test make check

@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 3, 2024

https://shaman.ceph.com/builds/ceph/wip-matanb-crimson-testing-nov-3/

@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 3, 2024

jenkins test make check

@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 3, 2024

https://pulpito.ceph.com/matan-2024-11-03_10:45:16-crimson-rados-wip-matanb-crimson-testing-nov-3-distro-crimson-smithi/

7978413, 7978439 - https://tracker.ceph.com/issues/67791
Seastore:
7978417 - https://tracker.ceph.com/issues/67823
7978430 - https://tracker.ceph.com/issues/68809
Infra:
7978415 - Error reimaging machines

@github-actions github-actions bot added the tests label Nov 3, 2024
@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 4, 2024

jenkins test make check

@Matan-B Matan-B force-pushed the wip-matanb-crimson-recovery-version branch from 6fa63de to d9d1455 Compare November 4, 2024 09:36
@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 5, 2024

jenkins test api

@Matan-B
crimson/osd/pg: introduce projected_log
7a2db2f 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
test/crimson/test_backfill: support projected log and pg log
0a76ec3 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-recovery-version branch from d9d1455 to 0a76ec3 Compare November 5, 2024 09:47
@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 5, 2024

jenkins test make check

1 similar comment
@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 5, 2024

jenkins test make check

@Matan-B
Copy link
Copy Markdown
Contributor Author

Matan-B commented Nov 5, 2024

jenkins test docs

@Matan-B Matan-B merged commit a91bcae into ceph:main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzarzynski rzarzynski rzarzynski left review comments

@xxhdx1985126 xxhdx1985126 xxhdx1985126 approved these changes

@athanatos athanatos Awaiting requested review from athanatos

Assignees

No one assigned

Labels

crimson ready-to-merge TESTED tests wip-matan-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Matan-B @athanatos @rzarzynski @xxhdx1985126