Skip to content

tests/scripts: use 'tell pg deep-scrub pgid' instead of 'tell pgid deep-scrub'#56745

Merged
ronen-fr merged 1 commit intoceph:mainfrom
ronen-fr:wip-rf-pgtell
Apr 24, 2024
Merged

tests/scripts: use 'tell pg deep-scrub pgid' instead of 'tell pgid deep-scrub'#56745
ronen-fr merged 1 commit intoceph:mainfrom
ronen-fr:wip-rf-pgtell

Conversation

@ronen-fr
Copy link
Contributor

@ronen-fr ronen-fr commented Apr 7, 2024

as older OSD versions do not support the former.

Fixes: https://tracker.ceph.com/issues/64972

@github-actions github-actions bot added the tests label Apr 7, 2024
@ronen-fr
tests/scripts: use 'tell pg deep-scrub pgid' instead of 'tell pgid
dda89e7 
deep-scrub'

as older OSD versions do not support the former.

Fixes: https://tracker.ceph.com/issues/64972

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
@ronen-fr
Copy link
Contributor Author

ronen-fr commented Apr 7, 2024

minimal Teuthology upgrade tests performed. They show that the change is enough to solve the specific upgrade tests failures I have analyzed.

@ronen-fr ronen-fr marked this pull request as ready for review April 7, 2024 19:15
@ronen-fr ronen-fr requested review from neha-ojha and rzarzynski April 7, 2024 19:15
@ronen-fr
Copy link
Contributor Author

ronen-fr commented Apr 8, 2024

jenkins test make check

@ronen-fr ronen-fr mentioned this pull request Apr 8, 2024
Closed
@rzarzynski
Copy link
Contributor

rzarzynski commented Apr 8, 2024

Looks unrelated:

Total Test time (real) = 1881.53 sec

The following tests FAILED:
	 22 - run-tox-cephadm (Failed)

@rzarzynski
Copy link
Contributor

rzarzynski commented Apr 8, 2024

jenkins test make check

@ljflores ljflores requested a review from athanatos April 8, 2024 15:16
rzarzynski
rzarzynski approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this makes teuthology happy. There was a discussion with @neha-ojha with the conclusion deep_scrub shouldn't be seen a part of our public interface (which I see very nice as the extra complexity can be jettisoned).

@ronen-fr ronen-fr mentioned this pull request Apr 8, 2024
Merged
@batrick
Copy link
Member

batrick commented Apr 10, 2024

much nicer!

@batrick
Copy link
Member

batrick commented Apr 11, 2024

jenkins test make check

@batrick
Copy link
Member

batrick commented Apr 17, 2024

This PR is under test in https://tracker.ceph.com/issues/65530.

@batrick
Copy link
Member

batrick commented Apr 18, 2024

This PR is under test in https://tracker.ceph.com/issues/65562.

@batrick
Copy link
Member

batrick commented Apr 20, 2024

This PR is under test in https://tracker.ceph.com/issues/65596.

@batrick
Copy link
Member

batrick commented Apr 22, 2024

https://tracker.ceph.com/projects/cephfs/wiki/Main#2024-04-20

CephFS approved. I don't see the deep-scrub errors anymore.

@ronen-fr
Copy link
Contributor Author

ronen-fr commented Apr 24, 2024

Merging. Thanks to the many reviewers and testers.

@ronen-fr ronen-fr merged commit 45d9f53 into ceph:main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@batrick batrick batrick approved these changes

@rzarzynski rzarzynski rzarzynski approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

@athanatos athanatos Awaiting requested review from athanatos

Assignees

No one assigned

Labels

backport squid bug-fix needs-qa tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ronen-fr @rzarzynski @batrick @vshankar