rgw: don't map to EIO in rgw_http_error_to_errno()#56704
Merged
Conversation
the http client uses EIO to detect connection errors specifically. if we map normal http errors to EIO, we incorrectly mark their endpoint as failed and route requests to other endpoints (if any exist) default to ERR_INTERNAL_ERROR (500 InternalError) instead Signed-off-by: Casey Bodley <cbodley@redhat.com>
14 tasks
Contributor
Author
|
it's hard to tell whether anything in multisite really depends on that mapping to EIO. i see some retry-on-EIO loops (ex https://github.com/ceph/ceph/blob/becfb26/src/rgw/driver/rados/rgw_data_sync.cc#L285-L286 and https://github.com/ceph/ceph/blob/becfb26/src/rgw/driver/rados/rgw_sync.cc#L513-L514) but it looks like those are meant to deal with connection errors |
Contributor
Author
|
@smanjara this was part of the same batch that passed qa with the fix from #56765 i scanned the three-zone teuthology.log and it looks like all of the normal checkpoint failures |
smanjara
approved these changes
Apr 9, 2024
Contributor
Author
|
this doesn't have a tracker, so i'll include its squid backport with #56765 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the http client uses EIO to detect connection errors specifically. if we map normal http errors to EIO, we incorrectly mark their endpoint as failed and route requests to other endpoints (if any exist)
default to ERR_INTERNAL_ERROR (500 InternalError) instead
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e