Skip to content

qa: do not iterate list being modified#56638

Merged
batrick merged 2 commits intoceph:mainfrom
batrick:i65022
Apr 22, 2024
Merged

qa: do not iterate list being modified#56638
batrick merged 2 commits intoceph:mainfrom
batrick:i65022

Conversation

@batrick
Copy link
Member

@batrick batrick commented Apr 2, 2024 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/65022

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions github-actions bot added cephfs Ceph File System tests labels Apr 2, 2024
@batrick batrick requested a review from a team April 2, 2024 14:20
@batrick batrick mentioned this pull request Apr 2, 2024
Closed
14 tasks
@batrick
Copy link
Member Author

batrick commented Apr 2, 2024

@leonid-s-usov please take a look at the quiescdb make check failure in this PR.

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Apr 2, 2024

@leonid-s-usov please take a look at the quiescdb make check failure in this PR.

@batrick I ran the test locally x1000 without reproduction. It looks like a test issue rather than a bug. Please re-run the test here while I try to reproduce it. I'll then submit a separate update to make the test more robust or fix an issue if any

@batrick
Copy link
Member Author

batrick commented Apr 2, 2024

jenkins test make check

@batrick
Copy link
Member Author

batrick commented Apr 2, 2024

jenkins test make check arm64

lxbsz
lxbsz approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@lxbsz lxbsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @batrick

vshankar
vshankar approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. But I wonder, what caused this test to trip now. My guess would be a change that started to spawn more background jobs.

@batrick
Copy link
Member Author

batrick commented Apr 3, 2024

Nice catch. But I wonder, what caused this test to trip now. My guess would be a change that started to spawn more background jobs.

It is a regression caused by bb71023

batrick added 2 commits April 3, 2024 09:08
@batrick
qa: remove unnecessary background job cleanup
98f161b 
This is done in CephFSTestCase.tearDown.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@batrick
qa: do not iterate list being modified
57022d9 
Fixes: https://tracker.ceph.com/issues/65022
Fixes: bb71023
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Apr 4, 2024

I ran the test locally x1000 without reproduction. It looks like a test issue rather than a bug. Please re-run the test here while I try to reproduce it. I'll then submit a separate update to make the test more robust or fix an issue if any

@batrick I can't reproduce this test failure, and there are no improvements I'd like to make in the test, as it should work well the way it is now. And maybe, it does :)

I guess we'll have to wait and see if this ever gets reproduced again

@batrick
Copy link
Member Author

batrick commented Apr 4, 2024

I ran the test locally x1000 without reproduction. It looks like a test issue rather than a bug. Please re-run the test here while I try to reproduce it. I'll then submit a separate update to make the test more robust or fix an issue if any

@batrick I can't reproduce this test failure, and there are no improvements I'd like to make in the test, as it should work well the way it is now. And maybe, it does :)

I guess we'll have to wait and see if this ever gets reproduced again

ack

@batrick
Copy link
Member Author

batrick commented Apr 4, 2024

jenkins test make check arm64

1 similar comment
@lxbsz
Copy link
Member

lxbsz commented Apr 9, 2024

jenkins test make check arm64

@leonid-s-usov
Copy link
Contributor

leonid-s-usov commented Apr 9, 2024

jenkins test make check arm64

don't bother, it's broken forever

@batrick
Copy link
Member Author

batrick commented Apr 17, 2024

This PR is under test in https://tracker.ceph.com/issues/65530.

@batrick
Copy link
Member Author

batrick commented Apr 18, 2024

This PR is under test in https://tracker.ceph.com/issues/65562.

@batrick
Copy link
Member Author

batrick commented Apr 20, 2024

This PR is under test in https://tracker.ceph.com/issues/65596.

@batrick
Copy link
Member Author

batrick commented Apr 22, 2024

https://tracker.ceph.com/projects/cephfs/wiki/Main#2024-04-20

@batrick batrick merged commit b71803b into ceph:main Apr 22, 2024
@batrick batrick deleted the i65022 branch April 22, 2024 19:06
@batrick batrick mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar approved these changes

@lxbsz lxbsz lxbsz approved these changes

+1 more reviewer

@leonid-s-usov leonid-s-usov leonid-s-usov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cephfs Ceph File System tests wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@batrick @leonid-s-usov @lxbsz @vshankar