I find it suspicious that the updated tests weren't failing before this change. @neesingh-rh, could you please verify that the tests are being run by teuthology?

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

There are more places to be addressed post #48732. The new minimum of 8 also invalidates some tests that try to set the property to 1. I found two such cases:

* `qa/tasks/cephfs/test_meta_injection.py:TestMetaInjection.test_meta_injection`

* `qa/workunits/restart/test-backtraces.py:flush()`

I'm not ready to say whether those tests will need a more significant refactoring or just set the value to the new minimum (8)

As asked by @leonid-s-usov , I did check some of the runs to check why the tests weren't failing before. I did check the code and we should be getting the error caught here: https://github.com/ceph/ceph/blob/main/src/common/ceph_context.cc#L613 . I didn't find this test being run in teuthology. @vshankar Any reason? Or Am I wrong somewhere.

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@neesingh-rh Do you plan to refurbish this change? As far as #56634 (comment) is concerned, please look into one of the latest fs suite runs to assess if the tests are being run and the relevant config (set to 1) is indeed getting exercised.

@neesingh-rh ping

@neesingh-rh ping

The PR addresses the requirements of the respective tracker. Need to look one of the latest runs for this comment:#56634 (comment)

@neesingh-rh Looks like test_meta_injection isn't run from anywhere

git grep test_meta_injection
qa/tasks/cephfs/test_meta_injection.py:    def test_meta_injection(self):

color me surprised o_O

@neesingh-rh Looks like test_meta_injection isn't run from anywhere

git grep test_meta_injection
qa/tasks/cephfs/test_meta_injection.py:    def test_meta_injection(self):

color me surprised o_O

yes, May be it was added to test it locally. I am not sure about the reason. But yeah, the PR updates the config option with its new min value. So, we can go ahead with this. What say?

@neesingh-rh Looks like test_meta_injection isn't run from anywhere

git grep test_meta_injection
qa/tasks/cephfs/test_meta_injection.py:    def test_meta_injection(self):

color me surprised o_O

yes, May be it was added to test it locally. I am not sure about the reason. But yeah, the PR updates the config option with its new min value. So, we can go ahead with this. What say?

Then let's add changes to start running the test. The type of the config is unsigned int, so setting to -1 should fail.

@neesingh-rh Looks like test_meta_injection isn't run from anywhere

git grep test_meta_injection
qa/tasks/cephfs/test_meta_injection.py:    def test_meta_injection(self):

color me surprised o_O

yes, May be it was added to test it locally. I am not sure about the reason. But yeah, the PR updates the config option with its new min value. So, we can go ahead with this. What say?

Then let's add changes to start running the test. The type of the config is unsigned int, so setting to -1 should fail.

@vshankar I have created a yaml file in suites/fs/functional/tasks to include it in test

@neesingh-rh Do you know where qa/workunits/restart/test-backtraces.py is run from?

@neesingh-rh Do you know where qa/workunits/restart/test-backtraces.py is run from?

Oh, this also needs to be taken care of!! I have no idea where should it be added.

@mchangir Your testing label has been added, any updates?

@mchangir Your testing label has been added, any updates?

probably this wasn't put to test
I'll remove the testing label, somebody else can pick it up

@rishabh-d-dave Can this be added in any of your runs?

jenkins test windows

This PR is under test in https://tracker.ceph.com/issues/71663.

This PR is under test in https://tracker.ceph.com/issues/71663.

A large number of jobs failed to an unrelated error, deferring QA run until it is fixed.

This PR is under test in https://tracker.ceph.com/issues/71703.

@rishabh-d-dave ping?

Had a chat with Neeraj regarding this PR. He misread this comment - #56634 (review) and will be taking a look into the failed QA job.

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

Reopened for Umbrella release.