crimson/osd/replicated_recovery_backend: prepare_pull use pg_info#56611
Merged
crimson/osd/replicated_recovery_backend: prepare_pull use pg_info#56611
Conversation
14 tasks
athanatos
reviewed
Apr 1, 2024
| recovery_info.ss = ssc->snapset; | ||
| auto subsets = crimson::osd::calc_clone_subsets( | ||
| ssc->snapset, soid, local_missing, last_backfill); | ||
| ssc->snapset, soid, local_missing, pg.get_info().last_backfill); |
Contributor
There was a problem hiding this comment.
"we may not have info from peer [fromshard], use pg's get_info instead." is wrong. It's not possible for us to be pulling from a peer for which we don't have an info (how would we know the peer has the object in the first place?).
This change does happen to be right because calc_clone_subsets here is being used to figure out which portions of the object need to be pulled from the replica to recover the primary. That calculation therefore needs last_backfill from the primary, not from the replica. However, I'm skeptical that this caused a problem because last_backfill on the primary must be max for it to have gone active.
Contributor
Author
There was a problem hiding this comment.
I amended the commit.
Don't use peer's info on prepare_pull. Fixes: https://tracker.ceph.com/issues/65200 Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4eb50a6 to
7586abf
Compare
athanatos
approved these changes
Apr 8, 2024
14 tasks
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use peer's info on prepare_pull.
Fixes: https://tracker.ceph.com/issues/65200
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e