Skip to content

osd/scrub: remove detection & handling of reservation timeouts from the code#56389

Merged
yuriw merged 3 commits intoceph:mainfrom
ronen-fr:wip-rf-qtimeout
Jun 5, 2024
Merged

osd/scrub: remove detection & handling of reservation timeouts from the code#56389
yuriw merged 3 commits intoceph:mainfrom
ronen-fr:wip-rf-qtimeout

Conversation

@ronen-fr
Copy link
Contributor

as no timeout can be set for reserver-based (queued) reservation requests.

Fixes: https://tracker.ceph.com/issues/65044

@ronen-fr ronen-fr marked this pull request as ready for review March 22, 2024 22:29
@ronen-fr ronen-fr requested a review from a team as a code owner March 22, 2024 22:29
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@yuriw
Copy link
Contributor

yuriw commented Apr 22, 2024

@ronen-fr pls rebase

@ronen-fr
Copy link
Contributor Author

@ronen-fr pls rebase

(Back from PTO... )
Done!

@ronen-fr
Copy link
Contributor Author

ronen-fr commented May 1, 2024

jenkins retest this please

@ronen-fr
Copy link
Contributor Author

ronen-fr commented May 1, 2024

I will be merging based on my tests and the Teuthology tests performed on the backport

@ronen-fr
Copy link
Contributor Author

ronen-fr commented May 1, 2024

jenkins test windows

ronen-fr added 3 commits May 2, 2024 03:18
as no timeout can be set for reserver-based (queued)
reservation requests.

Fixes: https://tracker.ceph.com/issues/65044
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
following the removal of the reservation timeout handling code.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
as the code that updates it, following a reservation timeout,
was removed.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
@ronen-fr ronen-fr force-pushed the wip-rf-qtimeout branch from 7eb2872 to 61e1b10 Compare May 2, 2024 08:20
@ronen-fr
Copy link
Contributor Author

ronen-fr commented May 2, 2024

jenkins test windows

@ronen-fr
Copy link
Contributor Author

ronen-fr commented May 2, 2024

jenkins test api

@yuriw
Copy link
Contributor

yuriw commented May 3, 2024

This PR is under test in https://tracker.ceph.com/issues/65797.

@yuriw yuriw merged commit 758aad3 into ceph:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants