Skip to content

crimson/osd/pg: use pgmeta_oid for snapmapper#56376

Closed
athanatos wants to merge 1 commit intoceph:mainfrom
athanatos:sjust/wip-64975-crimson-scrub-snapmapper
Closed

crimson/osd/pg: use pgmeta_oid for snapmapper#56376
athanatos wants to merge 1 commit intoceph:mainfrom
athanatos:sjust/wip-64975-crimson-scrub-snapmapper

Conversation

@athanatos
Copy link
Copy Markdown
Contributor

Using a new object for snapmapper is tricky. The only existing object like this is the pg meta object, which is special-cased in a variety of places through the osd. It also happens to have the nice property that it's not expressible through a normal rados operation -- rados objects are not allowed to have empty names.

This snapmapper object, on the other hand, could actually be the target of a user read or write (though it's unlikely to happen by accident). In order to do this correctly, the existing special cases for the pgmeta object would need to be generalized and the normal user IO path would need to disallow mutations (and maybe reads since these objects wouldn't follow normal rules).

Instead, let's just stick these keys into the pgmeta object and save ourselves a lot of work.

Fixes: https://tracker.ceph.com/issues/64975

https://pulpito.ceph.com/sjust-2024-03-21_02:35:36-crimson-rados-wip-sjust-crimson-testing-2024-03-20-distro-default-smithi/

Failures unrelated, caused by existing known bugs.

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment