crimson/osd/pg: use pgmeta_oid for snapmapper#56376
Closed
crimson/osd/pg: use pgmeta_oid for snapmapper#56376
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a new object for snapmapper is tricky. The only existing object like this is the pg meta object, which is special-cased in a variety of places through the osd. It also happens to have the nice property that it's not expressible through a normal rados operation -- rados objects are not allowed to have empty names.
This snapmapper object, on the other hand, could actually be the target of a user read or write (though it's unlikely to happen by accident). In order to do this correctly, the existing special cases for the pgmeta object would need to be generalized and the normal user IO path would need to disallow mutations (and maybe reads since these objects wouldn't follow normal rules).
Instead, let's just stick these keys into the pgmeta object and save ourselves a lot of work.
Fixes: https://tracker.ceph.com/issues/64975
https://pulpito.ceph.com/sjust-2024-03-21_02:35:36-crimson-rados-wip-sjust-crimson-testing-2024-03-20-distro-default-smithi/
Failures unrelated, caused by existing known bugs.
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e