crimson/.../scrub_events: fix progress lifetime in deep_scan_object#56375
Merged
crimson/.../scrub_events: fix progress lifetime in deep_scan_object#56375
Conversation
seastar::repeat may or may not move the passed action after the first invocation, so we can't actually rely on references to variables captured by value being stable. Instead, allocate with std::make_unique and move into a finally lambda. Fixes: https://tracker.ceph.com/issues/64996 Signed-off-by: Samuel Just <sjust@redhat.com>
cyx1231st
approved these changes
Mar 22, 2024
Member
|
jenkins test make check |
tchaikov
reviewed
Mar 22, 2024
| return interruptor::repeat( | ||
| [FNAME, this, progress = obj_scrub_progress_t(), | ||
| &obj, &entry, &pg]() mutable | ||
| [FNAME, this, &progress, &obj, &entry, &pg]() |
Contributor
There was a problem hiding this comment.
as a follow-up, is it possible to transform the interruptor::repeat() block to a plain loop in C++, now that the coroutine supported is added to crimson?
Contributor
Author
There was a problem hiding this comment.
The next time I make a large enough change here, the whole thing will be a coroutine with normal loops.
rzarzynski
approved these changes
Mar 22, 2024
Contributor
Author
|
jenkins test api |
liu-chunmei
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seastar::repeat may or may not move the passed action after the first invocation, so we can't actually rely on references to variables captured by value being stable. Instead, allocate with std::make_unique and move into a finally lambda.
Fixes: https://tracker.ceph.com/issues/64996
https://pulpito.ceph.com/sjust-2024-03-21_02:35:36-crimson-rados-wip-sjust-crimson-testing-2024-03-20-distro-default-smithi/
Failures unrelated, caused by existing known bugs.
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e