objclass: deprecate cls_cxx_gather by NitzanMordhai · Pull Request #55923 · ceph/ceph

NitzanMordhai · 2024-03-04T13:39:15Z

cls_cxx_gather is not maintained and having issues with retry. since there is no current use of it, we will deprecate it.

Fixes: https://tracker.ceph.com/issues/64258

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

ronen-fr · 2024-03-04T14:17:03Z

PendingReleaseNotes

   `ceph config get mgr mgr/volumes/snapshot_clone_no_wait`
  and it can be disabled by using:
   `ceph config set mgr mgr/volumes/snapshot_clone_no_wait false`
+* cls_cxx_gather will be marked as depreacted.


I'd guess it should read 'is marked as deprecated' or 'will be deprecated', but not both 'delay vectors'...

I agree with Ronen. Pulling @zdover23 in!

It is marked deprecated as of squid and may be removed in a future, unspecified release.

@NitzanMordhai: let's polish the note and pull the PR in.

@rzarzynski let me know if that is what we want.

I agree with @athanatos's rewrite.

rzarzynski · 2024-03-04T18:41:09Z

PendingReleaseNotes

   `ceph config get mgr mgr/volumes/snapshot_clone_no_wait`
  and it can be disabled by using:
   `ceph config set mgr mgr/volumes/snapshot_clone_no_wait false`
+* cls_cxx_gather will be marked as depreacted.


I agree with Ronen. Pulling @zdover23 in!

rzarzynski · 2024-03-04T18:41:20Z

src/crimson/osd/objclass.cc


 int cls_cxx_gather(cls_method_context_t hctx, const std::set<std::string> &src_objs, const std::string& pool,
-		   const char *cls, const char *method, bufferlist& inbl)
+		   const char *cls, const char *method, bufferlist& inbl) __attribute__ ((deprecated))


ACK.

UPDATE: oops, GCC says something different:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/crimson/osd/objclass.cc:556:77: error: GCC does not allow 'deprecated' attribute in this position on a function definition [-Werror,-Wgcc-compat] const char *cls, const char *method, bufferlist& inbl) __attribute__ ((deprecated))

@rzarzynski missed that, i completely removed that from crimson, and also removed the test since it is deprecated

rzarzynski · 2024-03-04T18:45:01Z

The PR is a follow-up to: #55410.

rzarzynski · 2024-03-05T11:13:06Z

src/crimson/osd/objclass.cc

-  return 0;
-}
-
-int cls_cxx_get_gathered_data(cls_method_context_t hctx, std::map<std::string, bufferlist> *results)


I'm fine with removing these functions in crimson assuming the plugins are still loadable (I bet they will be).

rzarzynski · 2024-03-23T12:13:40Z

PendingReleaseNotes

   `ceph config get mgr mgr/volumes/snapshot_clone_no_wait`
  and it can be disabled by using:
   `ceph config set mgr mgr/volumes/snapshot_clone_no_wait false`
+* cls_cxx_gather will be marked as depreacted.


@NitzanMordhai: let's polish the note and pull the PR in.

qa/workunits/rados/test.sh

github-actions · 2024-05-06T16:58:49Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

yuriw · 2024-05-06T19:17:02Z

By @kamoltat "RADOS APPROVED https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues65349"

yuriw · 2024-05-06T19:17:35Z

@NitzanMordhai pls rebase and merge it was approved

ref: https://tracker.ceph.com/issues/65349

cls_cxx_gather is not maintained and having issues with retry. since there is no current use of it, we will deprecate it. Fixes: https://tracker.ceph.com/issues/64258 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>

NitzanMordhai · 2024-05-09T12:50:12Z

jenkins test make check

NitzanMordhai · 2024-05-12T05:17:33Z

jenkins test make check

NitzanMordhai · 2024-05-12T05:17:53Z

jenkins test api

https://tracker.ceph.com/issues/64258 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>

NitzanMordhai · 2024-05-12T11:40:19Z

jenkins test make check

NitzanMordhai · 2024-05-13T05:13:31Z

jenkins test make check

NitzanMordhai requested a review from a team as a code owner March 4, 2024 13:39

github-actions bot added crimson documentation labels Mar 4, 2024

NitzanMordhai requested review from athanatos and rzarzynski March 4, 2024 13:39

ronen-fr reviewed Mar 4, 2024

View reviewed changes

rzarzynski reviewed Mar 4, 2024

View reviewed changes

NitzanMordhai force-pushed the wip-nitzan-add-deprecate-cls-gather branch from 53ea047 to 0fbfbad Compare March 5, 2024 11:07

NitzanMordhai requested a review from a team as a code owner March 5, 2024 11:07

github-actions bot added core tests labels Mar 5, 2024

rzarzynski reviewed Mar 5, 2024

View reviewed changes

rzarzynski requested changes Mar 23, 2024

View reviewed changes

NitzanMordhai force-pushed the wip-nitzan-add-deprecate-cls-gather branch from 0fbfbad to f87c4b7 Compare March 24, 2024 06:28

github-actions bot added the build/ops label Mar 24, 2024

rzarzynski approved these changes Mar 27, 2024

View reviewed changes

rzarzynski added the needs-qa label Mar 27, 2024

yuriw added the wip-yuri3-testing label Apr 5, 2024

github-actions bot added the needs-rebase label May 6, 2024

yuriw added TESTED ready-to-merge and removed wip-yuri3-testing labels May 6, 2024

objclass: deprecate cls_cxx_gather

6cddadf

cls_cxx_gather is not maintained and having issues with retry. since there is no current use of it, we will deprecate it. Fixes: https://tracker.ceph.com/issues/64258 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>

NitzanMordhai force-pushed the wip-nitzan-add-deprecate-cls-gather branch from f87c4b7 to d3ce638 Compare May 9, 2024 08:53

github-actions bot removed the needs-rebase label May 9, 2024

rados/test: Remove cls_remote_reade since gather deprecated

0928f7b

https://tracker.ceph.com/issues/64258 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>

NitzanMordhai force-pushed the wip-nitzan-add-deprecate-cls-gather branch from d3ce638 to 0928f7b Compare May 12, 2024 10:26

NitzanMordhai merged commit 6d36b0d into ceph:main May 13, 2024

NitzanMordhai deleted the wip-nitzan-add-deprecate-cls-gather branch May 13, 2024 06:00

NitzanMordhai mentioned this pull request Jun 2, 2024

squid: objclass: deprecate cls_cxx_gather #57819

Merged

This was referenced Oct 8, 2024

reef: objclass: deprecate cls_cxx_gather #60195

Merged

quincy: objclass: deprecate cls_cxx_gather #60196

Closed

Conversation

NitzanMordhai commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rzarzynski Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rzarzynski Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rzarzynski Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rzarzynski commented Mar 4, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented May 6, 2024

Uh oh!

yuriw commented May 6, 2024

Uh oh!

yuriw commented May 6, 2024

Uh oh!

NitzanMordhai commented May 9, 2024

Uh oh!

NitzanMordhai commented May 12, 2024

Uh oh!

NitzanMordhai commented May 12, 2024

Uh oh!

NitzanMordhai commented May 12, 2024

Uh oh!

NitzanMordhai commented May 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NitzanMordhai commented Mar 4, 2024 •

edited

Loading

rzarzynski Mar 4, 2024 •

edited

Loading

rzarzynski Mar 4, 2024 •

edited

Loading

rzarzynski Mar 4, 2024 •

edited

Loading