Skip to content

os/bluestore: Mute warnings#55872

Merged
yuriw merged 1 commit intoceph:mainfrom
aclamk:wip-aclamk-bs-fix-unused
Mar 18, 2024
Merged

os/bluestore: Mute warnings#55872
yuriw merged 1 commit intoceph:mainfrom
aclamk:wip-aclamk-bs-fix-unused

Conversation

@aclamk
Copy link
Contributor

@aclamk aclamk commented Mar 1, 2024

  • simplify op_bl size estimation
  • fix seq size estimation
  • skip useless calculation of crc32c

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

+ simplify op_bl size estimation
+ fix seq size estimation
+ skip useless calculation of crc32c

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
@aclamk aclamk requested a review from a team as a code owner March 1, 2024 14:04
@aclamk
Copy link
Contributor Author

aclamk commented Mar 1, 2024

Based on #55428, it also fixes some problems that were in original code.

Copy link
Contributor

@ifed01 ifed01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amathuria
Copy link
Contributor

@yuriw yuriw merged commit 459b79a into ceph:main Mar 18, 2024
@ifed01 ifed01 mentioned this pull request Aug 14, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants