Skip to content

crimson/os/seastore/omap_manager: expand omap tree nodes#55840

Merged
cyx1231st merged 1 commit intoceph:mainfrom
xxhdx1985126:wip-seastore-large-omap-nodes
Mar 5, 2024
Merged

crimson/os/seastore/omap_manager: expand omap tree nodes#55840
cyx1231st merged 1 commit intoceph:mainfrom
xxhdx1985126:wip-seastore-large-omap-nodes

Conversation

@xxhdx1985126
Copy link
Contributor

@xxhdx1985126 xxhdx1985126 commented Feb 29, 2024 •
edited
Loading

Teuthology tests can issue large omap kvs

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@xxhdx1985126 xxhdx1985126 requested a review from a team as a code owner February 29, 2024 13:40
cyx1231st
cyx1231st approved these changes Mar 1, 2024
View reviewed changes
@xxhdx1985126
crimson/os/seastore/omap_manager: expand omap tree nodes
94803e9 
Teuthology tests can issue large omap kvs

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
@xxhdx1985126 xxhdx1985126 force-pushed the wip-seastore-large-omap-nodes branch from fc25ce4 to 94803e9 Compare March 1, 2024 07:01
@cyx1231st
Copy link
Member

cyx1231st commented Mar 4, 2024

jenkins retest this please

@cyx1231st
Copy link
Member

cyx1231st commented Mar 4, 2024

Make check:

prometheus.cc:(.text+0x224ba): undefined reference to `google::protobuf::internal::ArenaStringPtr::Set(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, google::protobuf::Arena*)'
/usr/bin/ld: lib/libseastar.a(prometheus.cc.o): in function `seastar::prometheus::add_label(io::prometheus::client::Metric*, std::map<seastar::basic_sstring<char, unsigned int, 15u, true>, seastar::basic_sstring<char, unsigned int, 15u, true>, std::less<seastar::basic_sstring<char, unsigned int, 15u, true> >, std::allocator<std::pair<seastar::basic_sstring<char, unsigned int, 15u, true> const, seastar::basic_sstring<char, unsigned int, 15u, true> > > > const&, seastar::prometheus::config const&)':
prometheus.cc:(.text+0x26cc6): undefined reference to `google::protobuf::internal::ArenaStringPtr::Set(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, google::protobuf::Arena*)'
/usr/bin/ld: prometheus.cc:(.text+0x26f89): undefined reference to `google::protobuf::internal::ArenaStringPtr::Set(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, google::protobuf::Arena*)'
/usr/bin/ld: prometheus.cc:(.text+0x275df): undefined reference to `google::protobuf::internal::ArenaStringPtr::Set(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, google::protobuf::Arena*)'
/usr/bin/ld: prometheus.cc:(.text+0x277e2): undefined reference to `google::protobuf::internal::ArenaStringPtr::Set(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&&, google::protobuf::Arena*)'

@cyx1231st
Copy link
Member

cyx1231st commented Mar 4, 2024

jenkins test make check

1 similar comment
@cyx1231st
Copy link
Member

cyx1231st commented Mar 4, 2024

jenkins test make check

@cyx1231st
Copy link
Member

cyx1231st commented Mar 5, 2024

jenkins test make check

@cyx1231st cyx1231st merged commit 1dcbaf7 into ceph:main Mar 5, 2024
@cyx1231st
Copy link
Member

cyx1231st commented Mar 5, 2024

Teuthology tests can issue large omap kvs

btw @xxhdx1985126, can you point out the related test code about the large kvs, that might be useful to estimate the limit.

@xxhdx1985126 xxhdx1985126 deleted the wip-seastore-large-omap-nodes branch April 23, 2024 03:15
@Matan-B Matan-B mentioned this pull request May 7, 2024
Merged
@cyx1231st cyx1231st mentioned this pull request Aug 14, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyx1231st cyx1231st cyx1231st approved these changes

@liu-chunmei liu-chunmei liu-chunmei approved these changes

Assignees

No one assigned

Labels

crimson

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xxhdx1985126 @cyx1231st @liu-chunmei