mgr/dashboard: fix roles page for roles without policies #55771
mgr/dashboard: fix roles page for roles without policies #55771nizamial09 merged 1 commit intoceph:mainfrom
Conversation
|
jenkins test dashboard |
|
jenkins test make check |
| for role in roles: | ||
| if not 'PermissionPolicies' in role: | ||
| role['PermissionPolicies'] = [] |
There was a problem hiding this comment.
Just a question , thinking on this one.
This will add permission policies to the roles when not present, that means the "PermissionPolicies" field will always be visible on UI , is that okay for UI ?
There was a problem hiding this comment.
the default behaviour in the details tab is that even if something is empty, its good to show it to the user rather than hide it. In this case, this is an important feature for the roles. Also, the dashboard should have the ability to set policies for the roles. Something we could do in future. I don't remember if we have a tracker created for it.
There was a problem hiding this comment.
Alrighty then! Thanks!
Yes we have https://tracker.ceph.com/issues/64351
If there is no permission policies attached to a role, it fails the UI with an exception. Fixes: https://tracker.ceph.com/issues/64588 Signed-off-by: Nizamudeen A <nia@redhat.com>
|
jenkins test api |
If there is no permission policies attached to a role, it fails the UI with an exception.
Also fixes another issue which I recorded below
scrnli_2_27_2024_12-45-57.PM.mp4
Fixes: https://tracker.ceph.com/issues/64588
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e