Skip to content

cephfs-shell: prints warning, hangs and aborts when launched#55711

Merged
rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave:fsshell-deprecation
Apr 5, 2024
Merged

cephfs-shell: prints warning, hangs and aborts when launched#55711
rishabh-d-dave merged 1 commit intoceph:mainfrom
rishabh-d-dave:fsshell-deprecation

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Feb 22, 2024 •
edited by joscollin
Loading

Occured because Python module "pkg_resources" has been deprecated.

Fixes: https://tracker.ceph.com/issues/64538

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rishabh-d-dave rishabh-d-dave requested review from a team and neesingh-rh February 22, 2024 12:36
@neesingh-rh
Copy link
Contributor

neesingh-rh commented Feb 22, 2024

jenkins test make check

@rishabh-d-dave rishabh-d-dave added wip-rishabh-testing Rishabh's testing label and removed needs-review labels Feb 26, 2024
@joscollin
Copy link
Member

joscollin commented Feb 26, 2024

@rishabh-d-dave s/warnining/warning in commit message

rishabh-d-dave
rishabh-d-dave commented Apr 4, 2024
View reviewed changes
Copy link
Contributor Author

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do multiple QA runs and re-runs due to build issues (due to one of the PRs in testing branch), unrelated issues in FS test suite, unrelated issues in testing kernel and new failures in every run that needed to ensured that they were unrelated to PRs in testing branch.

I finally have a run that is better than others - https://tracker.ceph.com/projects/cephfs/wiki/Main#4-Apr-2024. Sorry for the delay.

@rishabh-d-dave
cephfs-shell: don't use pkg_resources since its deprecated
68b5766 
Currently, cephfs-shell prints warnings, hangs and aborts when launched.
This occurs because Python module "pkg_resources" has been deprecated.
We use that module only checking version of other Python modules used in
cephfs-shell. Use "Version" from "packaging.version" instead.

Fixes: https://tracker.ceph.com/issues/64538
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 4, 2024

Updated nothing more than the commit title and commit message.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 4, 2024

Will merge this PR as soon as CI is green for it.

@rishabh-d-dave rishabh-d-dave changed the title cephfs-shell: prints warnining, hangs and aborts when launched cephfs-shell: prints warning, hangs and aborts when launched Apr 4, 2024
@rishabh-d-dave rishabh-d-dave removed the wip-rishabh-testing Rishabh's testing label label Apr 4, 2024
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 5, 2024

On last make check (https://jenkins.ceph.com/job/ceph-pull-requests/132730/), unittest_posix_bucket_cache failed. This is unrelated to this PR.

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 5, 2024

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 5, 2024 •
edited
Loading

Success of QA run reported was added here - #55711 (review)

@rishabh-d-dave rishabh-d-dave merged commit e43c155 into ceph:main Apr 5, 2024
This was referenced Jun 17, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joscollin joscollin joscollin approved these changes

@neesingh-rh neesingh-rh neesingh-rh approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rishabh-d-dave @neesingh-rh @joscollin